Skip to content

Clean Code for bundles/org.eclipse.ui.browser#3305

Merged
HeikoKlare merged 2 commits intomasterfrom
clean-code/bundles/org.eclipse.ui.browser
Sep 22, 2025
Merged

Clean Code for bundles/org.eclipse.ui.browser#3305
HeikoKlare merged 2 commits intomasterfrom
clean-code/bundles/org.eclipse.ui.browser

Conversation

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

@eclipse-platform-bot
Copy link
Copy Markdown
Contributor Author

eclipse-platform-bot commented Sep 20, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.browser/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 1dc08f17bdf0d84bdc8fa4218656ed93d2dccbfe Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Mon, 22 Sep 2025 03:53:01 +0000
Subject: [PATCH] Version bump(s) for 4.38 stream


diff --git a/bundles/org.eclipse.ui.browser/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.browser/META-INF/MANIFEST.MF
index bbd680a30c..bb836775f3 100644
--- a/bundles/org.eclipse.ui.browser/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.browser/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.ui.browser; singleton:=true
-Bundle-Version: 3.8.600.qualifier
+Bundle-Version: 3.8.700.qualifier
 Bundle-Activator: org.eclipse.ui.internal.browser.WebBrowserUIPlugin
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
-- 
2.51.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 20, 2025

Test Results

 2 904 files  ±0   2 904 suites  ±0   1h 57m 54s ⏱️ - 1m 55s
 8 019 tests ±0   7 773 ✅  - 1  245 💤 ±0  1 ❌ +1 
23 591 runs  ±0  22 808 ✅  - 1  782 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 9874cbb. ± Comparison against base commit 2f6a390.

♻️ This comment has been updated with latest results.

Comment on lines +247 to 253
if (IUriSchemeProcessor.INSTANCE.canHandle(uri)) {
IUriSchemeProcessor.INSTANCE.handleUri(uri);
event.doit = false;
}
} catch (CoreException e) {
WebBrowserUIPlugin.logError(e.getMessage(), e);
WebBrowserUIPlugin.logError(e.getMessage(), e);
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting gets broken because surrounding code is wrongly formatted.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HeikoKlare HeikoKlare force-pushed the clean-code/bundles/org.eclipse.ui.browser branch 2 times, most recently from c25601f to d79fc9a Compare September 20, 2025 09:46
@eclipse-platform-bot eclipse-platform-bot force-pushed the clean-code/bundles/org.eclipse.ui.browser branch 2 times, most recently from f6c6260 to 93bb340 Compare September 22, 2025 03:48
@HeikoKlare HeikoKlare force-pushed the clean-code/bundles/org.eclipse.ui.browser branch from a0595ac to 9874cbb Compare September 22, 2025 09:02
@HeikoKlare
Copy link
Copy Markdown
Contributor

Failing test is unrelated: #370

@HeikoKlare HeikoKlare merged commit 8dc4f46 into master Sep 22, 2025
16 of 18 checks passed
@HeikoKlare HeikoKlare deleted the clean-code/bundles/org.eclipse.ui.browser branch September 22, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants