Fix race condition in MMenuItemTest by adding event loop processing #3450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-platform#1737 The test testElementHierarchyInContext_HandledItem was experiencing intermittent failures due to a race condition. After creating handler processing addons and activating parts, the handler registration may not have completed before the test triggered the menu item selection. This commit adds calls to contextRule.spinEventLoop() in both testElementHierarchyInContext_DirectItem and testElementHierarchyInContext_HandledItem to ensure all pending UI events are processed before triggering menu item selection. This is a standard pattern for preventing race conditions in Eclipse UI tests. The spinEventLoop() method processes all pending events in the Display event queue, ensuring that handler registration and context updates have completed before the test proceeds. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1737
The test testElementHierarchyInContext_HandledItem was experiencing intermittent failures due to a race condition. After creating handler processing addons and activating parts, the handler registration may not have completed before the test triggered the menu item selection.
This commit adds calls to contextRule.spinEventLoop() in both testElementHierarchyInContext_DirectItem and
testElementHierarchyInContext_HandledItem to ensure all pending UI events are processed before triggering menu item selection. This is a standard pattern for preventing race conditions in Eclipse UI tests.
The spinEventLoop() method processes all pending events in the Display event queue, ensuring that handler registration and context updates have completed before the test proceeds.
🤖 Generated with Claude Code