Skip to content

Clean Code for bundles/org.eclipse.jface #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akurtakov merged 1 commit into from
Nov 4, 2025
Merged

Clean Code for bundles/org.eclipse.jface #3492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions bundles/org.eclipse.jface/src/org/eclipse/jface/fieldassist/DecoratedField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,27 +181,32 @@ class Hover {
/**
* This info hover's shell.
*/
@Deprecated
Shell hoverShell;

/**
* The info hover text.
*/
@Deprecated
String text = EMPTY;

/**
* The region used to manage the shell shape
*/
@Deprecated
Region region;

/**
* Boolean indicating whether the last computed polygon location had an
* arrow on left. (true if left, false if right).
*/
@Deprecated
boolean arrowOnLeft = true;

/*
* Create a hover parented by the specified shell.
*/
@Deprecated
Hover(Shell parent) {
final Display display = parent.getDisplay();
hoverShell = new Shell(parent, SWT.NO_TRIM | SWT.ON_TOP
Expand Down Expand Up @@ -229,6 +234,7 @@ public void mouseDown(MouseEvent e) {
* border is true, compute the polygon inset by 1-pixel border. Consult
* the arrowOnLeft flag to determine which side the arrow is on.
*/
@Deprecated
int[] getPolygon(boolean border) {
Point e = getExtent();
int b = border ? 1 : 0;
Expand All @@ -246,6 +252,7 @@ int[] getPolygon(boolean border) {
* Dispose the hover, it is no longer needed. Dispose any resources
* allocated by the hover.
*/
@Deprecated
void dispose() {
if (!hoverShell.isDisposed()) {
hoverShell.dispose();
Expand All @@ -258,6 +265,7 @@ void dispose() {
/*
* Set the visibility of the hover.
*/
@Deprecated
void setVisible(boolean visible) {
if (visible) {
if (!hoverShell.isVisible()) {
Expand All @@ -273,6 +281,7 @@ void setVisible(boolean visible) {
* and location of the hover to hover near the specified control,
* pointing the arrow toward the target control.
*/
@Deprecated
void setText(String t, Control hoverNear, Control targetControl) {
if (t == null) {
t = EMPTY;
Expand Down Expand Up @@ -304,13 +313,15 @@ void setText(String t, Control hoverNear, Control targetControl) {
/*
* Return whether or not the hover (shell) is visible.
*/
@Deprecated
boolean isVisible() {
return hoverShell.isVisible();
}

/*
* Compute the extent of the hover for the current text.
*/
@Deprecated
Point getExtent() {
GC gc = new GC(hoverShell);
Point e = gc.textExtent(text);
Expand All @@ -323,6 +334,7 @@ Point getExtent() {
/*
* Compute a new shape for the hover shell.
*/
@Deprecated
void setNewShape() {
Region oldRegion = region;
region = new Region();
Expand Down
Loading