Improve JFace notification snippets and documentation#3810
Merged
vogella merged 1 commit intoMar 31, 2026
Conversation
Contributor
Contributor
|
This pull request changes some projects for the first time in this development cycle. An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch. Git patchFurther information are available in Common Build Issues - Missing version increments. |
Contributor
Author
|
Found an issue in the positioning of the Shell, fixed with #3814 |
ca115b7 to
1a6aa26
Compare
- Fix typo in Snippet001 filename (Notifcation -> Notification) - Fix inconsistent indentation in Snippet084 - Simplify Snippet085 to use builder API idiomatically instead of reparenting widgets - Add Snippet001 to JFaceSnippets.md - Clean up Notification section in JFaceSnippets.md: remove duplicate links, fix typos, improve descriptions See eclipse-platform#1226
1a6aa26 to
87b1cc6
Compare
Contributor
Author
|
Documentation change, so the Unit test failure is ignored |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notifcation→Notification) and class nameSee #1226
Test plan