Skip dot-folders (e.g. .git) when scanning for projects to import#3860
Merged
vogella merged 1 commit intoeclipse-platform:masterfrom Apr 7, 2026
Merged
Conversation
Contributor
Contributor
|
FYI I expect generally all builds will fail due to 502 errors from download.eclipse.org. |
Contributor
Author
Thanks for the info. |
Add a 'Skip folders starting with dot' checkbox (default: true) to both
the Smart Import wizard (SmartImportRootWizardPage) and the traditional
Import Existing Projects wizard (WizardProjectsImportPage).
When enabled, directories starting with '.' (such as .git, .svn, .hg)
are skipped during recursive project scanning, significantly improving
import performance for repositories with large .git folders.
The setting is persisted in dialog settings and defaults to true for
new installations.
Adds tests for both import wizards:
- ImportExistingProjectsWizardTest:
- test24: Verifies .git folder projects are skipped with default setting
- test25: Verifies .git folder projects are found when skip is disabled
- SmartImportTests:
- testSmartImportSkipsDotFolders: Integration test verifying .git
projects are not imported via the wizard
- testSmartImportJobSkipsDotFoldersInProposals: Verifies import
proposals filter out projects inside .git folders
The 'Skip dot folders' checkbox is a scanning option that affects which
folders are visited during project discovery, so it belongs before the
post-import option 'Close newly imported projects upon completion'.
Fixes eclipse-platform#3858
vogella
force-pushed
the
skip-dot-folders-on-import
branch
from
5194c7b to
f427fad
Compare
Contributor
Author
|
Sorry @merks missed the comment in the issue: There should always be a comma after ‘e.g.’ Follow-up PR coming |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Skip folders starting with '.' checkbox (default: true) to both import wizards:
When enabled, directories like
.git,.svn,.hgetc. are skipped during recursive project scanning, significantly improving import performance for repositories with large.gitfolders.The setting is persisted in dialog settings and defaults to
truefor new installations.Fixes #3858