Better button styling in workspace selection dialog#3918
Conversation
Test Results 852 files 852 suites 54m 36s ⏱️ Results for commit afec7dd. ♻️ This comment has been updated with latest results. |
|
@BeckerWdf can you test this? |
Didn't I already last week? |
This one is for your remark here: #3905 (comment) and AFAICS you did not give me feedback on this PR (which might solve your button styling). |
|
Ah sorry. I did test it. This PR solves it. Somehow I did not write that last week. |
Can you post a screenshot, please? |
|
With your change: Without your change: |
That looks like the same to me? The new one is better? Can you explain why? |
Look at the buttons. They are very different. The first one is correct (as all buttons in the IDE look this way). The second one is wrong. I already highlighted the difference in #3905 (comment). |
|
I assume you expected a blue button like in the original example you posted. If the above is sufficient I start testing it on Linux and Windows. Windows testing usually takes a bit longer for me. |
Sure. Having the button also in blue would be even better. But already this one is fetter then this strange "gradient" styled buttons. |
|
Linux Dark looks also really good: 
Linux Light (unchanged to last years release): 
|
|
Windows looks bad: 
|
vogella
force-pushed
the
testing-unstyle-buttons-workspace-dialog
branch
from
36d6113 to
376733d
Compare
|
With latest patch set (special fix only for Windows): 
|
|
Also with "recent workspaces" fine on windows with the latest patch 
|
vogella
force-pushed
the
testing-unstyle-buttons-workspace-dialog
branch
from
376733d to
14b62ec
Compare
vogella
changed the title
|
Tested on all platform, planning to merge this tomorrow. |
Skip the early dark-theme styling for Button controls in the workspace selection dialog at startup so buttons get the native macOS dark appearance instead, matching what the ThemeEngine applies later. Other widgets (Shell, Composite, Label, Link, ExpandableComposite) remain styled as before since the ThemeEngine is not yet available during workspace selection. On windows we still need to style the check buttons otherwise they look white. Fixes: eclipse-platform#3905
vogella
force-pushed
the
testing-unstyle-buttons-workspace-dialog
branch
from
14b62ec to
afec7dd
Compare
2 participants
The workspace selection dialog at IDE startup mimics dark-theme styling because the ThemeEngine is not yet available. On macOS this produces buttons that look different from the buttons on other dialogs (e.g.
File > Switch Workspace).This change skips the hard-coded dark styling for
Buttoncontrols only, so they get the native macOS dark appearance. All other widgets (Shell, Composite, Label, Link) continue to be styled as before.On Windows the check button needs styling otherwise it appears white.