Use ILog.of(Class) instead of Platform.getLog(Class)#3922
Merged
vogella merged 2 commits intoeclipse-platform:masterfrom Apr 22, 2026
Merged
Use ILog.of(Class) instead of Platform.getLog(Class)#3922vogella merged 2 commits intoeclipse-platform:masterfrom
vogella merged 2 commits intoeclipse-platform:masterfrom
Conversation
Replace the two remaining Platform.getLog(Class) call sites with the equivalent ILog.of(Class). Functionally identical (both return the bundle's ILog without going through the Activator), but aligns with the convention used across the rest of the repo after the recent logging cleanup passes. - org.eclipse.e4.ui.css.swt.theme: ThemeEngine - org.eclipse.ui.genericeditor: GenericEditorPreferencePage
"Cannot to save preferences." -> "Cannot save preferences."
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Platform.getLog(Class)call sites with the equivalentILog.of(Class)(inThemeEngineandGenericEditorPreferencePage), aligning with the convention used after the recent logging cleanup passes. Functionally identical (both return the bundle'sILogwithout a round-trip through the Activator).GenericEditorPreferencePagelog message: "Cannot to save preferences." -> "Cannot save preferences."Test plan
mvn clean compile -pl :org.eclipse.e4.ui.css.swt.theme,:org.eclipse.ui.genericeditor -Pbuild-individual-bundles-> BUILD SUCCESS