Use CloseTestWindowsExtension in GoBackForwardsTest#3934
Merged
vogella merged 1 commit intoeclipse-platform:masterfrom Apr 24, 2026
Merged
Use CloseTestWindowsExtension in GoBackForwardsTest#3934vogella merged 1 commit intoeclipse-platform:masterfrom
vogella merged 1 commit intoeclipse-platform:masterfrom
Conversation
Replace hand-rolled window listener and shell-leak detection with the existing JUnit 5 CloseTestWindowsExtension. Fixes eclipse-platform#3536
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hand-rolled window listener and shell-leak check in
GoBackForwardsTestwith the existing JUnit 5CloseTestWindowsExtension, removing about 70 lines of duplicated harness code. Behavior is unchanged: the extension performs the same window tracking and leaked-shell assertion that the test had inlined.Fixes #3536