Use TestExecutionListener to log test start and end in org.eclipse.ui.tests#4034
Use TestExecutionListener to log test start and end in org.eclipse.ui.tests#4034trancexpress wants to merge 1 commit into
Conversation
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
The change looks good to get the logging of execution orders for JUnit 5 UI tests again. I just don't think we should move the JUnit 4 rules until those tests have been migrated to JUnit 5.
| @Rule | ||
| public TestWatcher LOG_TESTRUN = TestRunLogUtil.LOG_TESTRUN; |
There was a problem hiding this comment.
These rules should not be removed before the test class has been migrated to JUnit 5. Otherwise the log output is lost until the migration is done. You can, e.g., see that the logs for this PR do not contain logging for the testIndependentWorkingSets of this class anymore whereas previous builds contain it.
There was a problem hiding this comment.
Where can I see the logs actually? I checked the build job link but nothing was immediately obvious.
I thought JUnit 4 tests would be run with the vintage engine, but the listener would still be notified, resulting in double logging. If that is not the case, no issue to keep the rule.
….tests Add a JUnit Jupiter TestExecutionListener to org.eclipse.ui.tests, which logs test start and end events via UIPlugin. The listener is defined in org.eclipse.ui.tests.harness, so that it can be reused by other test bundles. Fixes: eclipse-platform#4032
Sure, that makes things even more simple. If we do see duplicated logged starts/ends in the first I-build with the changes, we can check where and why. |
2 participants
Add a JUnit Jupiter
TestExecutionListenertoorg.eclipse.ui.tests, which logs test start and end events viaUIPlugin.The listener is defined in
org.eclipse.ui.tests.harness, so that it can be reused by other test bundles.Fixes: #4032