Merge AbstractCSSSWTEngineImpl into CSSSWTEngineImpl#4042
Merged
vogella merged 1 commit intoJun 1, 2026
Conversation
Contributor
Same housekeeping pattern as the previous core-engine merge: AbstractCSSSWTEngineImpl was an abstract layer with two abstract hooks (initializeCSSPropertyHandlers, initializeCSSElementProvider) whose only concrete subclass was CSSSWTEngineImpl. Inline the abstract layer into the concrete leaf, drop the two now-redundant template methods, and register the SWT element provider and the registry-driven property handler provider directly in the constructor. Bundle internal (x-friends only); no API surface changed. All 194 css.swt tests still pass. Contributes to eclipse-platform#3980
vogella
force-pushed
the
css-merge-abstract-swt-engine
branch
from
3268b10 to
97d9d17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same housekeeping pattern as the recent core-engine merge (#4040):
AbstractCSSSWTEngineImplwas an abstract layer with two abstract hooks (initializeCSSPropertyHandlers,initializeCSSElementProvider) whose only concrete subclass wasCSSSWTEngineImpl. This inlines the abstract layer into the concrete leaf, drops the two now-redundant template methods, and registers the SWT element provider and the registry-driven property handler provider directly in the constructor.The bundle is internal (
x-friendsonly), so no API surface changes. The net effect is one fewer class and a flatter, easier-to-follow engine setup. All css.swt tests still pass.Contributes to #3980