Skip to content

Y20241011-1000

@HeikoKlare HeikoKlare tagged this 11 Oct 13:08
The FindReplaceOverlay is currently realized as a separate shell (more
precisely, a JFace Dialog), which is placed at a proper position on top
of the workbench shell. This has some drawback:
- It has to manually adapt to movements of the parent shell or the
target part/widget
- It has to manually hide and show depending on visibility changes of
the target part/widget
- It does not follow events of the target immediately, i.e., movements
are always some milliseconds behind, minimize/maximize
operations/animations are not synchronous etc.
- It does not locate properly when the platform uses Wayland, as manual
shell positioning is not possible there

This change replaces the dialog-based implementation of the
FindReplaceOverlay with an in-place composite-based implementation. A
composite is created in the target widget and placed relative to this
composite. In consequence, the overlay automatically follows all move,
resize, hide/show operations of the target widget.

Fixes https://github.com/eclipse-platform/eclipse.platform.swt/issues/1447

Fixes https://github.com/eclipse-platform/eclipse.platform.ui/issues/2099

Fixes https://github.com/eclipse-platform/eclipse.platform.ui/issues/2246
Assets 2
Loading