Modernized help UI prototype: Fix deleting and applying a search scope#1781
Merged
iloveeclipse merged 1 commit intoeclipse-platform:masterfrom Mar 26, 2025
Merged
Modernized help UI prototype: Fix deleting and applying a search scope#1781iloveeclipse merged 1 commit intoeclipse-platform:masterfrom
iloveeclipse merged 1 commit intoeclipse-platform:masterfrom
Conversation
This fixes the following issues in the modernized help UI prototype: - Deleting a set search scope causes JavaScript error. - Applying via search scope drop-down, choosing "Scopes...", going to the scope and hitting "Apply" does not work; as workaround a search scope can directly selected via search scope drop-down.
Contributor
Contributor
|
Thank you Holger for this fix. I have tested it on Windows 11 and Linux RHEL 9.2 and it works fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the following issues in the modernized help UI prototype: