Don't run into NPE while hiding Breakpoints view #2152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`VariablesView.becomesHidden()` is setting `ViewerInputService.NULL_INPUT` which sets the `IViewerInputUpdate` "input element" to null and so the viewer input for `Breakpoints` view to null. This is expected case, however the code in `ViewerUpdateMonitor` and in `ChildrenUpdate` was not prepared to that valid use case and runs into NPE or reports errors in case where no error happens. To fix (and add more error context for possible remaining input issues), let the `VariablesView` provide last used `IViewerInputUpdate` object so it can be used by `ViewerUpdateMonitor`, and let the `ChildrenUpdate` code be aware about viewer input element being null (which is documented as possible value at `ViewerUpdateMonitor.getViewerInput()`). Additionally implemented `toString()` in all related objects that can be set in `ViewerInputUpdate`, so the data can be provided in the error reported by `ViewerUpdateMonitor` for all remaining use cases with "null" input. Fixes eclipse-platform#2150
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VariablesView.becomesHidden()is settingViewerInputService.NULL_INPUTwhich sets theIViewerInputUpdate"input element" to null and so the viewer input forBreakpointsview to null.This is expected case, however the code in
ViewerUpdateMonitorand inChildrenUpdatewas not prepared to that valid use case and runs into NPE or reports errors in case where no error happens.To fix (and add more error context for possible remaining input issues), let the
VariablesViewprovide last usedIViewerInputUpdateobject so it can be used byViewerUpdateMonitor, and let theChildrenUpdatecode be aware about viewer input element being null (which is documented as possible value atViewerUpdateMonitor.getViewerInput()).Additionally implemented
toString()in all related objects that can be set inViewerInputUpdate, so the data can be provided in the error reported byViewerUpdateMonitorfor all remaining use cases with "null" input.Fixes #2150