Fix change highlight placement in TextMergeViewer after zoom change#2595
Fix change highlight placement in TextMergeViewer after zoom change#2595HeikoKlare wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
Test Results 54 files ±0 54 suites ±0 38m 27s ⏱️ +53s For more details on these failures, see this check. Results for commit 4f1b7ef. ± Comparison against base commit 4d9d68a. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Pull request overview
Fixes incorrect placement of change-region highlights in TextMergeViewer after a Windows per-monitor zoom/DPI change by invalidating the cached line-height data when a zoom change occurs.
Changes:
- Adds an
SWT.ZoomChangedlistener to eachStyledTextto clear the line-height cache on zoom changes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...dles/org.eclipse.compare/compare/org/eclipse/compare/contentmergeviewer/TextMergeViewer.java
Outdated
Show resolved
Hide resolved
HeikoKlare
force-pushed
the
textmergeviewer-zoomchange-lineheights
branch
from
807c4b9 to
64f2c54
Compare
The TextMergeViewer caches line heights for painting the change region highlights. That cache is not invalidated upon a zoom change even though the cached line heights are only valid for one specific zoom. In consequence, the highlights are not properly placed after a zoom change anymore. This change clears the line height cached upon zoom change of the according canvas, which fixes the placement of change highlight regions after zoom changes.
HeikoKlare
force-pushed
the
textmergeviewer-zoomchange-lineheights
branch
from
64f2c54 to
4f1b7ef
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The TextMergeViewer caches line heights for painting the change region highlights. That cache is not invalidated upon a zoom change even though the cached line heights are only valid for one specific zoom. In consequence, the highlights are not properly placed after a zoom change anymore.
This change clears the line height cached upon zoom change of the according canvas, which fixes the placement of change highlight regions after zoom changes.
How to test
Just open a text compare viewer and move it between monitors of different zooms on Windows.
For example when moving from 125% to 100%, it looks like this:
Before
After