Skip to content

Fixes BreakpointLabelAction being enabled when selecting a BreakpointContainer#2648

Merged
MohananRahul merged 1 commit intoeclipse-platform:masterfrom
r-mennig:disable_breakpointlabelaction_for_breakpointcontainer_selection
May 5, 2026
Merged

Fixes BreakpointLabelAction being enabled when selecting a BreakpointContainer#2648
MohananRahul merged 1 commit intoeclipse-platform:masterfrom
r-mennig:disable_breakpointlabelaction_for_breakpointcontainer_selection

Conversation

@r-mennig
Copy link
Copy Markdown
Contributor

@r-mennig r-mennig commented May 4, 2026

Currently, the BreakpointLabelAction is enabled when selecting a single BreakpointContainer (e.g. by grouping the breakpoints view by enablement state and selecting the "Enabled" group entry).

image

For such selections, the action has no effect because org.eclipse.debug.internal.ui.actions.breakpoints.BreakpointLabelAction.run(IAction) returns instantly if something other than a single org.eclipse.debug.core.model.Breakpoint is selected (which is the correct behavior here, since breakpoint containers are not renamable in general).

image

This PR disables the action if something other than a single breakpoint is currently selected.

Note: Making the action invisible would be more correct here, but this would require a restructure of the breakpoint view context menu since the action extension point does not allow making actions invisible.

How to test / reproduce

  1. Set (at least) 1 active breakpoint and open the breakpoint view
  2. Group breakpoints by enablement
  3. Select the "Enabled" entry -> Context menu shows "Label" action, clicking the action has no effect

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

Test Results

    54 files  ±0      54 suites  ±0   34m 8s ⏱️ - 2m 18s
 4 850 tests ±0   4 828 ✅ ±0   22 💤 ±0  0 ❌ ±0 
12 438 runs  ±0  12 282 ✅ ±0  156 💤 ±0  0 ❌ ±0 

Results for commit 8c24ecf. ± Comparison against base commit 7c138cf.

This pull request removes 387 and adds 276 tests. Note that renamed tests count towards both.
, nl=[Ljava.lang.String;@10bad903]
, nl=[Ljava.lang.String;@138eac9f]
, nl=[Ljava.lang.String;@14e1214a]
, nl=[Ljava.lang.String;@1a6c8679]
, nl=[Ljava.lang.String;@1c93d91c]
, nl=[Ljava.lang.String;@1d112dbf]
, nl=[Ljava.lang.String;@1fc74fd3]
, nl=[Ljava.lang.String;@221e21ee]
, nl=[Ljava.lang.String;@2350ee6d]
, nl=[Ljava.lang.String;@240e7fb]
…
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[10] Parameters[limit=2, chunks=5, repeat=1, input=====
====, output=== ...
== ...
== ...
== ...
== ...
== ...
, nl=[Ljava.lang.String;@1927ff2d]
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[10] Parameters[limit=2, chunks=5, repeat=1, input=====
====, output=== ...
== ...
== ...
== ...
== ...
== ...
, nl=[Ljava.lang.String;@5379985a]
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[10] Parameters[limit=2, chunks=5, repeat=1, input=====
====, output=== ...
== ...
== ...
== ...
== ...
== ...
, nl=[Ljava.lang.String;@5c66a6ad]
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[11] Parameters[limit=2, chunks=1, repeat=1, input==========, output=== ...
, nl=[Ljava.lang.String;@4d32ede]
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[11] Parameters[limit=2, chunks=1, repeat=1, input==========, output=== ...
, nl=[Ljava.lang.String;@651e5038]
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[11] Parameters[limit=2, chunks=1, repeat=1, input==========, output=== ...
, nl=[Ljava.lang.String;@794b1fac]
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[12] Parameters[limit=2, chunks=1, repeat=1, input========
==, output=== ...
==, nl=[Ljava.lang.String;@61b4d99a]
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[12] Parameters[limit=2, chunks=1, repeat=1, input========
==, output=== ...
==, nl=[Ljava.lang.String;@6a37bd6b]
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[12] Parameters[limit=2, chunks=1, repeat=1, input========
==, output=== ...
==, nl=[Ljava.lang.String;@743b4b76]
org.eclipse.debug.tests.console.ConsoleOutputLineTruncateTest ‑ test(Parameters)[13] Parameters[limit=3, chunks=1, repeat=1, input==========, output==== ...
, nl=[Ljava.lang.String;@1e791302]
…

Copy link
Copy Markdown
Contributor

@SougandhS SougandhS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this 👍

@MohananRahul MohananRahul merged commit 44abd61 into eclipse-platform:master May 5, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants