Fixes BreakpointLabelAction being enabled when selecting a BreakpointContainer#2648
Merged
MohananRahul merged 1 commit intoeclipse-platform:masterfrom May 5, 2026
Conversation
Contributor
Test Results 54 files ±0 54 suites ±0 34m 8s ⏱️ - 2m 18s Results for commit 8c24ecf. ± Comparison against base commit 7c138cf. This pull request removes 387 and adds 276 tests. Note that renamed tests count towards both. |
SougandhS
approved these changes
May 5, 2026
Contributor
SougandhS
left a comment
There was a problem hiding this comment.
Thanks for taking care of this 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the BreakpointLabelAction is enabled when selecting a single BreakpointContainer (e.g. by grouping the breakpoints view by enablement state and selecting the "Enabled" group entry).
For such selections, the action has no effect because org.eclipse.debug.internal.ui.actions.breakpoints.BreakpointLabelAction.run(IAction) returns instantly if something other than a single org.eclipse.debug.core.model.Breakpoint is selected (which is the correct behavior here, since breakpoint containers are not renamable in general).
This PR disables the action if something other than a single breakpoint is currently selected.
Note: Making the action invisible would be more correct here, but this would require a restructure of the breakpoint view context menu since the action extension point does not allow making actions invisible.
How to test / reproduce