Drop stale event-type count from IResourceChangeEvent class Javadoc#2665
Merged
vogella merged 1 commit intoMay 18, 2026
Merged
Conversation
The class Javadoc claimed "There are currently five different types of resource change events" but the bullet list immediately below it enumerates six (PRE_BUILD, POST_BUILD, POST_CHANGE, PRE_CLOSE, PRE_DELETE, PRE_REFRESH). The count drifted when PRE_REFRESH was added and would drift again whenever a new type is introduced, so replace the count with "The following types of resource change events are reported:".
Contributor
Contributor
Author
|
Just a Javadoc change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class Javadoc on
IResourceChangeEventclaims "There are currently five different types of resource change events", but the bullet list immediately below it enumerates six (PRE_BUILD,POST_BUILD,POST_CHANGE,PRE_CLOSE,PRE_DELETE,PRE_REFRESH). The count went stale whenPRE_REFRESHwas added and will keep drifting, so the fix replaces it with a count-free phrasing.