Skip to content

I20250911-1800

I20250911-1800: Don't run into NPE while hiding Breakpoints view
@iloveeclipse iloveeclipse tagged this 10 Sep 15:05 
`VariablesView.becomesHidden()` is setting
`ViewerInputService.NULL_INPUT` which sets the `IViewerInputUpdate`
"input element" to null and so the viewer input for `Breakpoints` view
to null.

This is expected case, however the code in `ViewerUpdateMonitor` and in
`ChildrenUpdate` was not prepared to that valid use case and runs into
NPE or reports errors in case where no error happens.

To fix (and add more error context for possible remaining input issues),
let the `VariablesView` provide last used `IViewerInputUpdate` object so
it can be used by `ViewerUpdateMonitor`, and let the `ChildrenUpdate`
code be aware about viewer input element being null (which is documented
as possible value at `ViewerUpdateMonitor.getViewerInput()`).

Additionally implemented `toString()` in all related objects that can be
set in `ViewerInputUpdate`, so the data can be provided in the error
reported by `ViewerUpdateMonitor` for all remaining use cases with
"null" input.

Fixes https://github.com/eclipse-platform/eclipse.platform/issues/2150
Assets 2
Loading