fix(api):ensure actioncontroller returns actual error status to client[#94]#97
Merged
youngtaekiim merged 2 commits intoeclipse-pullpiri:refactoringfrom Jun 10, 2025
Merged
Conversation
…#94] Previously, the gRPC server in actioncontroller always returned a success (OK) status, even when internal errors occurred. This prevented filtergateway from detecting and handling errors correctly. This fix ensures proper error propagation and accurate status reporting to the client.
Contributor
Author
|
Hi @youngtaekiim @leeeunkoo |
Contributor
|
good error handling for debugging. |
Contributor
Author
Hi @youngtaekiim, I've started working on refining the gRPC sender/receiver error handling across other modules. I'll provide updates incrementally, and I've already created an issue for the ActionController to track progress."#98 And please merge this PR if it's fine. |
akshaylg0314
force-pushed
the
refactoring
branch
from
cda0bba to
ff55278
Compare
chaehee-lim
pushed a commit
to chaehee-lim/pullpiri
that referenced
this pull request
Sep 3, 2025
fix(api):ensure actioncontroller returns actual error status to client[eclipse-pullpiri#94]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Description
Ensure ActionController returns the actual error status to the client
Previously, the gRPC server in actioncontroller always returned a success (OK) status, even when internal errors occurred. This prevented FilterGateway from detecting and handling errors correctly. This fix ensures proper error propagation and accurate status reporting to the client.
🔗 Related Issue
Closes #94
🧪 Test Method
sudo cargo test -- passes all unit test cases for filtergateway
📸 Screenshots
✅ Checklist
[✅] Code conventions are followed
[✅] Tests are added/modified
[X] Documentation is updated (if necessary)