Skip to content

Add unit test in skeleton_event.h for checking timestamp #87#125

Closed
ShoroukRamzy wants to merge 2 commits intoeclipse-score:mainfrom
Valeo-S-CORE-Organization:skeleton-event-ts-test
Closed

Add unit test in skeleton_event.h for checking timestamp #87#125
ShoroukRamzy wants to merge 2 commits intoeclipse-score:mainfrom
Valeo-S-CORE-Organization:skeleton-event-ts-test

Conversation

@ShoroukRamzy
Copy link
Copy Markdown
Contributor

@ShoroukRamzy ShoroukRamzy commented Dec 18, 2025

Hi @LittleHuba,

This PR resolves issue #87 and verifies that SkeletonEvent::Send correctly updates the timestamp in the shared memory control data.

Thanks!

@ShoroukRamzy ShoroukRamzy changed the title test lola add unit test for skeleton event timestamp Add unit test in skeleton_event.h for checking timestamp #87 Dec 18, 2025
@ShoroukRamzy
Copy link
Copy Markdown
Contributor Author

ShoroukRamzy commented Dec 18, 2025

Hi @LittleHuba , @castler and @hoe-jo,

Could you please let me know your feedbacks and help me merge this PR if possible? I don't have sufficient permissions to merge.

Thanks!

@ShoroukRamzy ShoroukRamzy force-pushed the skeleton-event-ts-test branch from 3b60016 to 11eccb3 Compare December 24, 2025 12:57
LittleHuba
LittleHuba reviewed Jan 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@LittleHuba LittleHuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, we had vacation over Christmas and New Year.
I left you some comments. In general the test is really good. I would only prefer if we can make it more resilient against unrelated changes.

As a bonus you could try to make more variables const.

Comment thread score/mw/com/impl/bindings/lola/skeleton_event_test.cpp Outdated
ASSERT_TRUE(first_send_result.has_value());

// THEN its timestamp should be a valid, non-zero value
auto first_final_slot_status = EventSlotStatus(first_slot_indicator.GetSlotQM().load());
Copy link
Copy Markdown
Contributor

@LittleHuba LittleHuba Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auto first_final_slot_status = EventSlotStatus(first_slot_indicator.GetSlotQM().load());
const EventSlotStatus first_final_slot_status{first_slot_indicator.GetSlotQM().load()};

Comment thread score/mw/com/impl/bindings/lola/skeleton_event_test.cpp Outdated

// THEN its timestamp should be a valid, non-zero value
auto first_final_slot_status = EventSlotStatus(first_slot_indicator.GetSlotQM().load());
EXPECT_FALSE(first_final_slot_status.IsInWriting());
Copy link
Copy Markdown
Contributor

@LittleHuba LittleHuba Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assert is IMHO not relevant for this test. Better remove it to make this test less impacted by unrelated changes in the codebase.

Comment thread score/mw/com/impl/bindings/lola/skeleton_event_test.cpp Outdated
Comment on lines +361 to +362
auto second_initial_status = EventSlotStatus(second_slot_indicator.GetSlotQM().load());
ASSERT_TRUE(second_initial_status.IsInWriting());
Copy link
Copy Markdown
Contributor

@LittleHuba LittleHuba Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auto second_initial_status = EventSlotStatus(second_slot_indicator.GetSlotQM().load());
ASSERT_TRUE(second_initial_status.IsInWriting());

Comment thread score/mw/com/impl/bindings/lola/skeleton_event_test.cpp Outdated
Comment on lines +340 to +341
auto first_initial_status = EventSlotStatus(first_slot_indicator.GetSlotQM().load());
ASSERT_TRUE(first_initial_status.IsInWriting());
Copy link
Copy Markdown
Contributor

@LittleHuba LittleHuba Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assert is IMHO not relevant for this test. Better remove it to make this test less impacted by unrelated changes in the codebase.

Suggested change
auto first_initial_status = EventSlotStatus(first_slot_indicator.GetSlotQM().load());
ASSERT_TRUE(first_initial_status.IsInWriting());

Comment thread score/mw/com/impl/bindings/lola/skeleton_event_test.cpp Outdated
Comment on lines +368 to +369
auto second_final_slot_status = EventSlotStatus(second_slot_indicator.GetSlotQM().load());
EXPECT_FALSE(second_final_slot_status.IsInWriting());
Copy link
Copy Markdown
Contributor

@LittleHuba LittleHuba Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
auto second_final_slot_status = EventSlotStatus(second_slot_indicator.GetSlotQM().load());
EXPECT_FALSE(second_final_slot_status.IsInWriting());
const EventSlotStatus second_final_slot_status{second_slot_indicator.GetSlotQM().load()};

@pahmann
Copy link
Copy Markdown
Member

pahmann commented Jan 7, 2026

I wonder if the test case touches any requirement and therefore should make use of test properties.
See process description here: https://eclipse-score.github.io/process_description/main/process_areas/verification/guidance/verification_templates.html#c-properties-template

@ShoroukRamzy ShoroukRamzy force-pushed the skeleton-event-ts-test branch 2 times, most recently from 6118a3f to 9b1fa2c Compare January 12, 2026 08:03
@ShoroukRamzy
Copy link
Copy Markdown
Contributor Author

ShoroukRamzy commented Jan 12, 2026

Hi @LittleHuba, Thank you for your feedbacks. I applied all the changes.
Please check and let me know if you have further feedbacks. if not, please help me merge this PR as I don't have sufficient permissions.
Thanks!

@ShoroukRamzy
Copy link
Copy Markdown
Contributor Author

ShoroukRamzy commented Jan 14, 2026

Hi @LittleHuba, Please let me know if you have any other feedbacks. Thanks!

@ShoroukRamzy ShoroukRamzy force-pushed the skeleton-event-ts-test branch from 9cff799 to 2588d00 Compare January 15, 2026 09:06
@LittleHuba LittleHuba added the import-started-do-not-modify Import of the PR was started. No further modifications allowed. label Jan 28, 2026
@castler castler closed this in 92d96ab Feb 4, 2026
Thomas-Mikhael pushed a commit to etas-contrib/score_communication that referenced this pull request Feb 25, 2026
@ShoroukRamzy @Thomas-Mikhael
test_lola: add unit test for skeleton event timestamp
76c60e0 
Closes eclipse-score#125

GIT_ORIGIN_SPP_REV_ID: 8eb5f87b2e469377a58eb8072b85cfbec4e280aa
Thomas-Mikhael pushed a commit to etas-contrib/score_communication that referenced this pull request Apr 13, 2026
@ShoroukRamzy @Thomas-Mikhael
test_lola: add unit test for skeleton event timestamp
026162a 
Closes eclipse-score#125

GIT_ORIGIN_SPP_REV_ID: 8eb5f87b2e469377a58eb8072b85cfbec4e280aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LittleHuba LittleHuba LittleHuba left review comments

@castler castler Awaiting requested review from castler castler is a code owner

@hoe-jo hoe-jo Awaiting requested review from hoe-jo hoe-jo is a code owner

Assignees

No one assigned

Labels

import-started-do-not-modify Import of the PR was started. No further modifications allowed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShoroukRamzy @pahmann @LittleHuba