Introduce ServiceElementMapView#475
Merged
Merged
Conversation
crimson11
requested review from
LittleHuba,
bemerybmw,
castler,
hoe-jo and
limdor
as code owners
crimson11
force-pushed
the
mf_generic_skelon_events_no_const
branch
2 times, most recently
from
79da223 to
5c98980
Compare
crimson11
added
the
test-qnx
bemerybmw
requested changes
May 27, 2026
crimson11
force-pushed
the
mf_generic_skelon_events_no_const
branch
from
5c98980 to
2fb31d3
Compare
bemerybmw
requested changes
May 28, 2026
bemerybmw
reviewed
May 28, 2026
bemerybmw
reviewed
May 28, 2026
crimson11
force-pushed
the
mf_generic_skelon_events_no_const
branch
4 times, most recently
from
bdd87a4 to
2ab3c40
Compare
bemerybmw
reviewed
May 29, 2026
crimson11
force-pushed
the
mf_generic_skelon_events_no_const
branch
from
2ab3c40 to
f7124fd
Compare
bemerybmw
approved these changes
May 29, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Up to now GenericProxy and GenericSkeleton provided inconsistent views for their contained events. This commit now introduces a common solution with ServiceElementMapView, which solves both issues: - map itself is immutable (no addition/removal of events) - events within the maps are mutable Issue: #467
Introduction of ServiceElementMapView required a design doc update. Issue: #467
crimson11
force-pushed
the
mf_generic_skelon_events_no_const
branch
from
08a061a to
1088562
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Up to now GenericProxy and GenericSkeleton provided inconsistent views for their contained events.
This commit now introduces a common solution with
ServiceElementMapView, which solves both issues:
Issue: #467