use clang_tidy from aspect_rules_lint#8
Closed
phongt wants to merge 3 commits intoeclipse-score:mainfrom
Closed
Conversation
phongt
force-pushed
the
apply_clang_tidy_from_aspect_rules_lint
branch
from
31df588 to
8004529
Compare
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
phongt
referenced
this pull request
May 29, 2025
It seems that such checks were forgotten to be migrated to the safe-posix-platform repo as part of mw/com. Issue: SWP-175649 GIT_ORIGIN_SPP_REV_ID: 0985aca9b95ece3a939a9b253c1dc3ae82aac900
Signed-off-by: Phong Tran <tranmanphong@gmail.com>
phongt
force-pushed
the
apply_clang_tidy_from_aspect_rules_lint
branch
from
8004529 to
33e3f2e
Compare
Add config build with clang as optional and apply to clang-tidy. Signed-off-by: Phong Tran <tranmanphong@gmail.com>
phongt
force-pushed
the
apply_clang_tidy_from_aspect_rules_lint
branch
from
bd3613e to
3107462
Compare
Contributor
|
Thank you for your contribution! In general, if you want to contribute something to S-CORE you have to sign the Eclipse ECA agreement. For this particular proposal, when we created our clang-tidy aspects, the open source one did not exist yet. We are planning to open source ours, and are checking if we can maybe integrate our extended features to the already open sourced one you mentioned. But right now we would have no plan to relay on this module. |
Contributor
Author
|
@castler thank you for your feedback of the proposal . I close the PR now as the issue already addressed b60e1af#diff-ddfd00285269d0a8d1275f566736ac678491641b79cf6451b463984571b9cf34R15 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a problem of 7bd5428 using the bazel rules from internal
//platform/aas/quality/clang_tidy:extra_checks.bzlPropose using the open source solution from https://github.com/aspect-build/rules_lint for clang-tidy.
Run clang-tidy with bazel command eg: