feat: add lcov to devcontainer image#119
Merged
Merged
Conversation
Install lcov as part of the devcontainer so that individual CI workflows no longer need to install it via apt-get at runtime. This decouples build tooling from workflow definitions, moving towards reproducible and hermetic build environments. Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
|
Ye this for sure makes sense I would say. The devcontainer should provide everything we need in S-CORE outa the box. |
lurtz
requested changes
May 26, 2026
Contributor
lurtz
left a comment
There was a problem hiding this comment.
Please also add a version check in the tests:
Signed-off-by: Dan Calavrezo <195309321+dcalavrezo-qorix@users.noreply.github.com>
lurtz
approved these changes
May 26, 2026
|
🎉 This PR is included in version 1.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install lcov as part of the devcontainer so that individual CI workflows no longer need to install it via apt-get at runtime. This decouples build tooling from workflow definitions, moving towards reproducible and hermetic build environments.