Skip to content

Conversation

@PandaeDo
Copy link
Contributor

@PandaeDo PandaeDo commented Jul 9, 2025

Bugfix for attributes linkage of DFA to static diagrams and changed mitigates to optional link if the violation doesn't apply

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //src:license-check

Status: ✅ Passed

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server and connecting to it...
INFO: Invocation ID: 24b20b5a-05f6-439b-aa3c-6821e930320c
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: src
Loading: 0 packages loaded
    currently loading: src
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //src:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //src:license-check (103 packages loaded, 10 targets configured)

Analyzing: target //src:license-check (147 packages loaded, 1471 targets configured)

Analyzing: target //src:license-check (153 packages loaded, 2641 targets configured)

Analyzing: target //src:license-check (158 packages loaded, 2687 targets configured)

Analyzing: target //src:license-check (162 packages loaded, 4820 targets configured)

INFO: Analyzed target //src:license-check (163 packages loaded, 4946 targets configured).
[11 / 13] Building src/license.check.license_check.jar (); 0s disk-cache
INFO: Found 1 target...
Target //src:license.check.license_check up-to-date:
  bazel-bin/src/license.check.license_check
  bazel-bin/src/license.check.license_check.jar
INFO: Elapsed time: 15.709s, Critical Path: 0.43s
INFO: 13 processes: 4 disk cache hit, 9 internal.
INFO: Build completed successfully, 13 total actions
INFO: Running command line: bazel-bin/src/license.check.license_check src/formatted.txt -review -project automotive.score -repo https://github.com/eclipse-score/docs-as-code -token otyhZ4eaRYK1tKLNNF-Y
[main] INFO Querying Eclipse Foundation for license data for 83 items.
[main] INFO Found 58 items.
[main] INFO Querying ClearlyDefined for license data for 25 items.
[main] INFO Found 25 items.
[main] INFO Vetted license information was found for all content. No further investigation is required.

@github-actions
Copy link

github-actions bot commented Jul 9, 2025

The created documentation from the pull request is available at: docu-html

Comment on lines 533 to +537
mitigates: ^(feat_req__.*|aou_req__.*)$
verifies: ^feat_arc_dyn__[0-9a-z_]*$
verifies: ^feat_arc_sta__[0-9a-z_]*$
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for feat_saf_dfa mitigates is a mandatory link, not optional like above?

Should it not be always the same?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I'm still working on it as discussed today. Now we have a better solution so I changed it back and we can check and merge the fix for the DFA.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is now correct, as it is? With the links being mandatory?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The links are mandatory. Because if a failure model is applicable than you must have a mitigation. Other way round and that's the good news when it doesn't apply we don't need even longer to document it in that way that we put in the related fault model and than document in the content that it doesn't apply.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you then change mandatory / optional things to be the same everywhere?

I see sufficent being optional and the new option of `violation_applicable' etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed back to sufficient

@PandaeDo PandaeDo marked this pull request as ready for review July 10, 2025 14:09
Copy link
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MaximilianSoerenPollak MaximilianSoerenPollak dismissed their stale review July 14, 2025 09:54

Figuring out why tests are failing

@MaximilianSoerenPollak
Copy link
Contributor

Iam very confused why the tests don't pass in CI. They do on my machine.
image

@PandaeDo PandaeDo force-pushed the vohae_saf_analysis branch from 4bf16a7 to bc95678 Compare July 14, 2025 12:11
Copy link
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for rebasing

@MaximilianSoerenPollak MaximilianSoerenPollak merged commit def3774 into eclipse-score:main Jul 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants