-
Notifications
You must be signed in to change notification settings - Fork 20
Bugfix: Attribute Safety Analysis #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Attribute Safety Analysis #131
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //src:license-checkStatus: ✅ Passed Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
| mitigates: ^(feat_req__.*|aou_req__.*)$ | ||
| verifies: ^feat_arc_dyn__[0-9a-z_]*$ | ||
| verifies: ^feat_arc_sta__[0-9a-z_]*$ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So for feat_saf_dfa mitigates is a mandatory link, not optional like above?
Should it not be always the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I'm still working on it as discussed today. Now we have a better solution so I changed it back and we can check and merge the fix for the DFA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is now correct, as it is? With the links being mandatory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The links are mandatory. Because if a failure model is applicable than you must have a mitigation. Other way round and that's the good news when it doesn't apply we don't need even longer to document it in that way that we put in the related fault model and than document in the content that it doesn't apply.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will you then change mandatory / optional things to be the same everywhere?
I see sufficent being optional and the new option of `violation_applicable' etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed back to sufficient
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Figuring out why tests are failing
4bf16a7 to
bc95678
Compare
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for rebasing

Bugfix for attributes linkage of DFA to static diagrams and changed mitigates to optional link if the violation doesn't apply