Add pre-commit config & upgrade devcontainer#411
Draft
MaximilianSoerenPollak wants to merge 36 commits intoeclipse-score:mainfrom
Draft
Add pre-commit config & upgrade devcontainer#411MaximilianSoerenPollak wants to merge 36 commits intoeclipse-score:mainfrom
MaximilianSoerenPollak wants to merge 36 commits intoeclipse-score:mainfrom
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //src:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
Upgraded devcontainer from 1.0 -> 1.2 Added basic pre-commit configuration file Added README instructions
e355b24 to
8e28246
Compare
lurtz
reviewed
Feb 24, 2026
| { | ||
| "name": "eclipse-s-core", | ||
| "image": "ghcr.io/eclipse-score/devcontainer:1.0.0", | ||
| "image": "ghcr.io/eclipse-score/devcontainer:v1.2.0", |
There was a problem hiding this comment.
Can you add this and tell me if you stell need PIPX_BIN_DIR to execute pre-commit?
Suggested change
| "image": "ghcr.io/eclipse-score/devcontainer:v1.2.0", | |
| "image": "ghcr.io/eclipse-score/devcontainer:v1.2.0", | |
| "postCreateCommand": "echo \"export PATH=$PIPX_BIN_DIR:$PATH\" | sudo tee /etc/bash_completion.d/add_pipx_to_path", |
There was a problem hiding this comment.
This only works in conjunction with devcontainer/cli. If this works I can add this to the image.
There was a problem hiding this comment.
Now I found a solution, which works in /etc/profile.d/. This took me way too long time
Suggested change
| "image": "ghcr.io/eclipse-score/devcontainer:v1.2.0", | |
| "image": "ghcr.io/eclipse-score/devcontainer:v1.2.0", | |
| "postCreateCommand": "echo \"export PATH=$PIPX_BIN_DIR:$PATH\" | sudo tee /etc/profile.d/add_pipx_to_path.sh", |
There was a problem hiding this comment.
Will be taken care of with eclipse-score/devcontainer#98
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded devcontainer from 1.0 -> 1.2
Added basic pre-commit configuration file
Added README instructions
📌 Description
Upgraded devcontainer from 1.0 -> 1.2
Added basic pre-commit configuration file
Added README instructions
This theoretically should work if executed inside the devcontainer, everywhere I tested it, it did.
However I could not get basedpyright to run inside there too for some odd reason ;/ not sure why.
🚨 Impact Analysis
✅ Checklist