requirements#67
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run //src:license-checkStatus: Click to expand output |
eaf58ff to
5693a05
Compare
|
The created documentation from the pull request is available at: docu-html |
3224d3d to
b1891b7
Compare
Co-authored-by: Maximilian Sören Pollak <MaximilianSoerenPollak@users.noreply.github.com>
Co-authored-by: Alexander Lanin <Alexander.Lanin@bosch.com>
Added needpie to showcase implemeneted status Removed some TODOs Added notes where applicable Changed headers to be similar to the rest
c8098b7 to
d4e8140
Compare
Iteration on tool_reqs
Co-authored-by: Maximilian Sören Pollak <MaximilianSoerenPollak@users.noreply.github.com>
|
@MaximilianSoerenPollak I've just tried rebasing and squashing all of this. I ended up with 0 changes. I don't see any need to clean this PR up before final review. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the initial docs-as-code requirements and landing pages by adding new product and how-to guides, updating the root and product indexes, and adjusting build and editor configurations.
- Added product landing with “Features” and “Requirements” cards and updated toctree
- Introduced core “Capabilities”, “How to Use”, and “How to Integrate” documentation
- Updated Bazel and external-needs configuration, enabled Myst colon-fence, and added VSCode settings
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/product/index.rst | Updated product index grid layout and toctree entries |
| docs/product/extensions/metamodel.md | Removed outdated “Getting started” link |
| docs/product/capabilities.md | Added new capabilities document |
| docs/index.rst | Revised main index cards and expanded sitemap toctree |
| docs/how-to-use/index.rst | Added “How To Use” landing page |
| docs/how-to-integrate/index.rst | Added “How to Integrate” landing page |
| docs/how-to-integrate/getting_started.md | Updated example link and removed extensions overview |
| docs/how-to-integrate/example/testing/index.rst | Updated need ID in example |
| docs/how-to-integrate/example/index.rst | Updated need ID in example |
| docs/conf.py | Enabled myst_enable_extensions = ["colon_fence"] |
| docs/BUILD | Added external_needs_info and targets for score_process |
| MODULE.bazel | Added bazel_dep for score_process |
| .vscode/settings.json | Reformatted Bazel LSP args and disabled internal type checking |
Comments suppressed due to low confidence (3)
docs/product/extensions/metamodel.md:6
- The Getting Started link was removed; consider replacing it with a pointer to the new 'How to Integrate' or 'How to Use' guide so readers can find setup instructions for this extension.
See [Getting started](../getting_started) for more information on why we use extensions.
docs/how-to-use/index.rst:12
- The toctree references 'faq', but no docs/how-to-use/faq.rst file exists. Please verify the filename or add the missing FAQ document.
* faq
docs/how-to-integrate/getting_started.md:129
- The 'Available Extensions' section was removed, potentially leaving users without guidance. Ensure that extension overviews are available elsewhere or link them from a central index.
## Available Extensions
I think overall the PR looks good. We have now gone over it quiet a bit. |
MaximilianSoerenPollak
left a comment
There was a problem hiding this comment.
Just the comments, but those can be fixed / addressed in later PR's.
Glad we can finally merge this, what a saga.
| - Latest documentation (e.g. `main` branch) | ||
| - ✅ Keeps linked repositories and their rendered websites unaffected by incoming references | ||
| - Allows bidirectional links for integration-focused documentation | ||
| - In addition to high level versioning of repositories, supports verifying suspect links on a requirement level |
There was a problem hiding this comment.
Not quiet sure what suspect links are.
There was a problem hiding this comment.
Random website:
A link is 'Suspect' when the Object was modified more recently than the corresponding link attribute
There was a problem hiding this comment.
We should add that to our documentation/glossary
| - ✅ Live preview functionality for documentation authors | ||
| - ✅ Integrated linting for: | ||
| - Syntax and formatting (reST and Markdown) | ||
| - Internal and external link validity |
There was a problem hiding this comment.
Internal yes (through sphinx / esbonio) ?
There was a problem hiding this comment.
I think that was meant to refer to external needs. And those are checked.
Co-authored-by: Maximilian Sören Pollak <maximilian.pollak@expleogroup.com>
initial set of docs-as-code requirements