Separate workflow approval from build job in QNX workflow#80
Merged
Conversation
ltekieli
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
Extract approval into a dedicated job and add merge_group trigger so the build job can be skipped for merge queue events while still requiring manual approval on pull requests.
ltekieli
force-pushed
the
lt_qnx_workflow_approval_merge
branch
from
7979ddb to
9af1712
Compare
ltekieli
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
ltekieli
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
github-project-automation
Bot
moved this from Backlog
to Done
in TST - Testing Community
ltekieli
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
ltekieli
force-pushed
the
lt_qnx_workflow_approval_merge
branch
from
4798cb6 to
43cb110
Compare
ltekieli
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
The post-exit drain loop broke after a single 0.1s select check even when data was still in transit through the SSH transport, causing truncation and a -1 exit code for large outputs. Now the drain reads data inline and loops until true EOF. Also reduce the large-stdout test from 5000x65B to 1000x256B iterations and raise max_exec_time from 30s to 60s so it completes within the timeout on emulated QNX QEMU targets.
ltekieli
force-pushed
the
lt_qnx_workflow_approval_merge
branch
from
43cb110 to
ebe4983
Compare
ltekieli
temporarily deployed
to
workflow-approval
GitHub Actions
Inactive
antonkri
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract approval into a dedicated job and add merge_group trigger so the build job can be skipped for merge queue events while still requiring manual approval on pull requests.