Add Unit tests for SafeProcessMap and OSHandler class#213
Merged
NicolasFussberger merged 6 commits intoJun 3, 2026
Merged
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
TimoSteuerwaldETAS
suggested changes
May 28, 2026
TimoSteuerwaldETAS
suggested changes
May 28, 2026
45fa89c to
db3ee30
Compare
TimoSteuerwaldETAS
approved these changes
Jun 2, 2026
pahmann
approved these changes
Jun 3, 2026
Member
pahmann
left a comment
There was a problem hiding this comment.
Approve this PR after independent review was conducted by subject matter expert missing committer status. Acting on behalf of the contributor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds unit tests for SafeProcessMap and OSHandler classes.
To improve testability, two small changes are done:
ProcessInfoNodeclassscore::os::SysWaitfor better testability of thewait()systemcall