CW_17 export by Y-Vaishnavi · Pull Request #100 · eclipse-score/logging

Y-Vaishnavi · 2026-04-27T12:48:08Z

Target adaptations to migrate to single RegistryAwareRecorderFactory (IRecorderFactory) implementation which now sits in score_baselibs. It provides a static plugin-based design that enables per-binary backend selection enabling single 'mw/log' target for all.
Updated documentation with new puml files for detailed design
Bug Fixes and optimizations resolving Severity 1, 2 based on adaptive autosar C++17 coding guidelines.
Update direct deps: score_baselibs to v0.2.7 and score_communication to v0.2.1
Regenerate [MODULE.bazel.lock] for updated dependencies

Notes for Reviewer

Pre-Review Checklist for the PR Author

PR title is short, expressive and meaningful
Commits are properly organized
Relevant issues are linked in the References section
Tests are conducted
Unit tests are added

Checklist for the PR Reviewer

Commits are properly organized and messages are according to the guideline
Unit tests have been written for new behavior
Public API is documented
PR title describes the changes

Post-review Checklist for the PR Author

All open points are addressed and tracked via issues

References

Closes #

github-actions · 2026-04-27T12:48:44Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: a87907c6-87d6-4ea2-a2f3-edda3da41970
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.8.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.9.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.17 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@2.3.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.5.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_tooling', the root module requires module version score_tooling@1.1.2, but got score_tooling@1.2.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.3, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_crates', the root module requires module version score_crates@0.0.6, but got score_crates@0.0.9 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0.bcr.1, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rapidjson', the root module requires module version rapidjson@1.1.0, but got rapidjson@1.1.0.bcr.20241007 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
Analyzing: 0 targets (5 packages loaded)
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 7.931s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

github-actions · 2026-04-27T12:50:46Z

The created documentation from the pull request is available at: docu-html

rmaddikery · 2026-04-27T15:06:31Z

Waiting for QNX8 builds to succeed ..

rmaddikery · 2026-04-27T15:09:22Z

@@ -100,14 +100,14 @@ bazel_dep(name = "rapidjson", version = "1.1.0")
 bazel_dep(name = "score_baselibs", version = "0.2.4")


bazel_dep(name = "score_baselibs", version = "0.2.6")

Updated in latest commit, Thanks!

rmaddikery · 2026-04-27T15:09:46Z

    remote = "https://github.com/eclipse-score/baselibs.git",
 )

 bazel_dep(name = "score_communication", version = "0.1.2")


bazel_dep(name = "score_communication", version = "0.2.0")

Updated in latest commit, Thanks!

rmaddikery

bump the direct deps (baselibs and communication) to latest versions please. The goal of this export is to keep logging in sync with the latest releases of those for v0.7

rmaddikery

46f9d2f#r3163729448

- Update score_baselibs commit to latest main (e87426c8) - Update score_communication commit to latest main (bc1e3c54) - Replace backend_table with minimal target in backend BUILD (backend_table visibility restricted to baselibs subpackages) - Replace recorder_factory with console target in score_log_bridge BUILD - Replace recorder_factory with console target in score_log_bridge_cpp_init BUILD

- @score_baselibs//score/mw/log target that supports additive backends should be used instead.

rmaddikery

LGTM. Great, git_overrides are removed

pawelrutkaq · 2026-04-30T07:58:34Z

    deps = [
        ":ffi",
        # Link dependency required by `:ffi`.
-        "//score/mw/log/detail/common:recorder_factory",


seems to be wrong. The Bridge shall link a backend becasue its considered a RUST backend

Although the backends reside in score_logging, the backend registration sits in baselibs. That's why this deps.

pawelrutkaq · 2026-04-30T07:59:42Z

    visibility = ["//visibility:private"],
    deps = [
-        "//score/mw/log/detail/common:recorder_factory",
-        "@score_baselibs//score/mw/log:frontend",


seems to be wrong. The Bridge shall link a backend becasue its considered a RUST backend

- Links all available mw/log C++ backends in the rust log_bridge so that the users get all backends without adding the deps themselves. - A todo note linked to an issue to track and resolve the tech debt after its resolved.

Y-Vaishnavi requested review from 4og and antonkri as code owners April 27, 2026 12:48

Y-Vaishnavi requested a deployment to workflow-approval April 27, 2026 12:48 — with GitHub Actions Waiting

Y-Vaishnavi requested a deployment to workflow-approval April 27, 2026 12:53 — with GitHub Actions Waiting

Y-Vaishnavi marked this pull request as draft April 27, 2026 13:48

Y-Vaishnavi requested a deployment to workflow-approval April 27, 2026 13:50 — with GitHub Actions Waiting

Y-Vaishnavi force-pushed the 7CECE363F0EE64EE11A5B7EC828632DD branch from 72c6b50 to 00b02a6 Compare April 27, 2026 14:06

Y-Vaishnavi requested a deployment to workflow-approval April 27, 2026 14:06 — with GitHub Actions Waiting

Y-Vaishnavi force-pushed the 7CECE363F0EE64EE11A5B7EC828632DD branch from 00b02a6 to 1db44c2 Compare April 27, 2026 14:10

Y-Vaishnavi requested a deployment to workflow-approval April 27, 2026 14:11 — with GitHub Actions Waiting

rmaddikery marked this pull request as ready for review April 27, 2026 15:03

rmaddikery requested review from arsibo and pawelrutkaq as code owners April 27, 2026 15:03

rmaddikery approved these changes Apr 27, 2026

View reviewed changes

Y-Vaishnavi changed the title ~~Export changes after running copybara from spp~~ CW_17 export Apr 27, 2026

rmaddikery reviewed Apr 27, 2026

View reviewed changes

rmaddikery requested changes Apr 27, 2026

View reviewed changes

Y-Vaishnavi force-pushed the 7CECE363F0EE64EE11A5B7EC828632DD branch from 1db44c2 to f78ec36 Compare April 27, 2026 15:12

Y-Vaishnavi requested a deployment to workflow-approval April 27, 2026 15:12 — with GitHub Actions Waiting

Y-Vaishnavi requested a review from rmaddikery April 27, 2026 15:13

Y-Vaishnavi temporarily deployed to workflow-approval April 29, 2026 15:14 — with GitHub Actions Inactive

rmaddikery previously approved these changes Apr 29, 2026

View reviewed changes

Y-Vaishnavi dismissed rmaddikery’s stale review via c524f0c April 29, 2026 17:11

Y-Vaishnavi force-pushed the 7CECE363F0EE64EE11A5B7EC828632DD branch from a01ffe0 to c524f0c Compare April 29, 2026 17:11

Y-Vaishnavi requested a deployment to workflow-approval April 29, 2026 17:11 — with GitHub Actions Waiting

Y-Vaishnavi force-pushed the 7CECE363F0EE64EE11A5B7EC828632DD branch from c524f0c to 4f3e438 Compare April 29, 2026 17:25

Y-Vaishnavi requested a deployment to workflow-approval April 29, 2026 17:25 — with GitHub Actions Waiting

rmaddikery reviewed Apr 29, 2026

View reviewed changes

Comment thread score/mw/log/backend/BUILD Outdated

rmaddikery reviewed Apr 29, 2026

View reviewed changes

Comment thread score/mw/log/backend/BUILD Outdated

rmaddikery reviewed Apr 29, 2026

View reviewed changes

Y-Vaishnavi and others added 3 commits April 30, 2026 07:51

Fix: Adds missing x86_64_qnx feature to rust_test target

680833a

Adds deprecation warning for mw/log target

eac00f8

- @score_baselibs//score/mw/log target that supports additive backends should be used instead.

Y-Vaishnavi force-pushed the 7CECE363F0EE64EE11A5B7EC828632DD branch from 4f3e438 to eac00f8 Compare April 30, 2026 05:52

Y-Vaishnavi temporarily deployed to workflow-approval April 30, 2026 05:52 — with GitHub Actions Inactive

rmaddikery previously approved these changes Apr 30, 2026

View reviewed changes

pawelrutkaq requested changes Apr 30, 2026

View reviewed changes

pawelrutkaq reviewed Apr 30, 2026

View reviewed changes

score_log_bridge: add file, remote, and slog backend deps

6fb7f46

- Links all available mw/log C++ backends in the rust log_bridge so that the users get all backends without adding the deps themselves. - A todo note linked to an issue to track and resolve the tech debt after its resolved.

rmaddikery dismissed their stale review via 6fb7f46 April 30, 2026 09:07

rmaddikery temporarily deployed to workflow-approval April 30, 2026 09:07 — with GitHub Actions Inactive

rmaddikery deployed to workflow-approval April 30, 2026 09:07 — with GitHub Actions Active

pawelrutkaq approved these changes Apr 30, 2026

View reviewed changes

rmaddikery approved these changes Apr 30, 2026

View reviewed changes

antonkri self-requested a review April 30, 2026 09:40

antonkri approved these changes Apr 30, 2026

View reviewed changes

antonkri merged commit 2dc9290 into eclipse-score:main Apr 30, 2026
14 checks passed

		@@ -100,14 +100,14 @@ bazel_dep(name = "rapidjson", version = "1.1.0")
		bazel_dep(name = "score_baselibs", version = "0.2.4")

Conversation

Y-Vaishnavi commented Apr 27, 2026 • edited by rmaddikery Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notes for Reviewer

Pre-Review Checklist for the PR Author

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

References

Uh oh!

github-actions Bot commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License Check Results

Uh oh!

github-actions Bot commented Apr 27, 2026

Uh oh!

rmaddikery commented Apr 27, 2026

Uh oh!

rmaddikery Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Y-Vaishnavi Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

rmaddikery Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Y-Vaishnavi Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

rmaddikery left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rmaddikery left a comment

Choose a reason for hiding this comment

Uh oh!

rmaddikery left a comment

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

rmaddikery Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Y-Vaishnavi commented Apr 27, 2026 •

edited by rmaddikery

Loading

github-actions Bot commented Apr 27, 2026 •

edited

Loading

rmaddikery left a comment •

edited

Loading