Skip to content

CW_19 export#116

Merged
rmaddikery merged 10 commits into
eclipse-score:mainfrom
Y-Vaishnavi:7CECE363F0EE64EE11A5B7EC828632DD
May 15, 2026
Merged

CW_19 export#116
rmaddikery merged 10 commits into
eclipse-score:mainfrom
Y-Vaishnavi:7CECE363F0EE64EE11A5B7EC828632DD

Conversation

@Y-Vaishnavi
Copy link
Copy Markdown
Contributor

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • PR title is short, expressive and meaningful
  • Commits are properly organized
  • Relevant issues are linked in the References section
  • Tests are conducted
  • Unit tests are added

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 15, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 39b4dc3f-1ac6-4127-9aa0-d8a914c5e5b7
Computing main repo mapping: 
WARNING: For repository 'rules_python', the root module requires module version rules_python@1.4.1, but got rules_python@1.8.3 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'bazel_skylib', the root module requires module version bazel_skylib@1.7.1, but got bazel_skylib@1.9.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rules_cc', the root module requires module version rules_cc@0.1.1, but got rules_cc@0.2.17 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'aspect_rules_lint', the root module requires module version aspect_rules_lint@1.0.3, but got aspect_rules_lint@2.3.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'buildifier_prebuilt', the root module requires module version buildifier_prebuilt@7.3.1, but got buildifier_prebuilt@8.5.1 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_tooling', the root module requires module version score_tooling@1.1.2, but got score_tooling@1.2.0 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.3, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'score_crates', the root module requires module version score_crates@0.0.6, but got score_crates@0.0.9 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'googletest', the root module requires module version googletest@1.17.0.bcr.1, but got googletest@1.17.0.bcr.2 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
WARNING: For repository 'rapidjson', the root module requires module version rapidjson@1.1.0, but got rapidjson@1.1.0.bcr.20241007 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 4 packages loaded
Loading: 4 packages loaded
    currently loading: 
WARNING: Target pattern parsing failed.
ERROR: Skipping '//:license-check': no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
ERROR: no such target '//:license-check': target 'license-check' not declared in package '' defined by /home/runner/work/logging/logging/BUILD
INFO: Elapsed time: 6.050s
INFO: 0 processes.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@github-actions
Copy link
Copy Markdown

The created documentation from the pull request is available at: docu-html

@Y-Vaishnavi Y-Vaishnavi force-pushed the 7CECE363F0EE64EE11A5B7EC828632DD branch from b4bbdac to 415bf9e Compare May 15, 2026 06:54
Pawel Pyszko and others added 10 commits May 15, 2026 09:08
GIT_ORIGIN_SPP_REV_ID: ccee3ff06c66001cb4edd7e7fa247b10341c3c0b
GIT_ORIGIN_SPP_REV_ID: d73a3df3c30c8fbdc334be2713a125b7c8bf8003
If logging uses unistd, it should be declared and do not rely on
transitive dependencies.

GIT_ORIGIN_SPP_REV_ID: df0a41928e0af28842efce12c0ea71a71b50a259
In the moment we take message_passing from score, it is no longer
a bmw::os::Error but a score::os::Error

GIT_ORIGIN_SPP_REV_ID: a6547b61a5ac9581ec562e429758e8aef26634a9
- Line 330 and 335: Change const to constexpr in CreateSender() method.
- Line 355: Replace lambda explicit pointer captures with captures of [this].

This complies with AUTOSAR rule A5-1-4 which addresses lambda lifetime
safety concerns and AUTOSAR rule A7-1-2 which requires compile-time
constants to be declared as constexpr rather than const.

GIT_ORIGIN_SPP_REV_ID: 120729476d5e588ca6c0d78580c5fd7f69f96728
GIT_ORIGIN_SPP_REV_ID: 40394c1e4c76aefffd731bc0a27d75c7430812a2
GIT_ORIGIN_SPP_REV_ID: bf09e4eb44b827446205f17e1b195a56bd32c73b
GIT_ORIGIN_SPP_REV_ID: af67725823b5f7ebca465d1fd8aaf7428471ac29
GIT_ORIGIN_SPP_REV_ID: aeef50cb3bcd10d6dc4aa801c80984e1c659510b
- The DLT Trace backend's intent is to integrate the
GTL and its respective backend that supports Shm as
transport mode with DMA capability.

GIT_ORIGIN_SPP_REV_ID: b47ae777804b88d7b83ce332960a90369d8a6bb0
@Y-Vaishnavi Y-Vaishnavi force-pushed the 7CECE363F0EE64EE11A5B7EC828632DD branch from 415bf9e to 78bac32 Compare May 15, 2026 07:09
@Y-Vaishnavi Y-Vaishnavi deployed to workflow-approval May 15, 2026 07:09 — with GitHub Actions Active
@Y-Vaishnavi Y-Vaishnavi temporarily deployed to workflow-approval May 15, 2026 07:09 — with GitHub Actions Inactive
@Y-Vaishnavi Y-Vaishnavi marked this pull request as ready for review May 15, 2026 07:15
Copy link
Copy Markdown
Contributor

@rmaddikery rmaddikery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmaddikery rmaddikery merged commit 5270e48 into eclipse-score:main May 15, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants