-
Notifications
You must be signed in to change notification settings - Fork 21
testing: reorganize tests #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
testing: reorganize tests #58
Conversation
4dad25d to
3385d00
Compare
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
|
The created documentation from the pull request is available at: docu-html |
PiotrKorkus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general the concept of keeping unit tests together with implementation is the proffered way according to Rust documentation. There are different opinions on that in SCORE but as long as file doesn't look like 10% implementation, 90% tests I think it is a good move.
83d73da to
58f7fdf
Compare
PiotrKorkus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, let's wait for final decision from Vinod
- Remove redundant files. - Reduce number of test files. - Move `common.rs` to `common/mod.rs` as recommended by Rust Book. - Uniform `derive` usage in `kvs_api.rs`. - Bazel target for unit tests.
58f7fdf to
e9b7ce0
Compare
…ests testing: reorganize tests
common.rstocommon/mod.rsas recommended by Rust Book.deriveusage inkvs_api.rs.