Skip to content

Update: bazel and module dependency update #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AlexanderLanin merged 3 commits into from
Aug 8, 2025
Merged

Update: bazel and module dependency update #64

AlexanderLanin merged 3 commits into from
Aug 8, 2025

Conversation

@umaucher
Copy link
Contributor

@umaucher umaucher commented Aug 7, 2025

  • Update bazel to 8.3.0 (incl. buildifier (best matching, latest 8.2.0.2)
  • googletest 1.14.0 -> 1.15.0
  • score_cr_checker 0.2.2 -> 0.3.1
  • aspect_rules_lint 1.0.3 -> 1.4.4
  • score-baselibs commit
    ae349b99cafc1e79d98c0391a851fc5664c04ebc ->
    46923f5c4f302bd9feae0261588687aaf32e3c5c

umaucher added 2 commits August 7, 2025 17:57
@umaucher
inc_mw_per: Update bazel to 8.3.0
a3bd51a 
Similar to the module_template update to bazel 8.3.0 and update the buildifier
to "the closest" matching one.
@umaucher
MODULE.bazel: Update versions of dependencies
df11c6d 
Update versions of the dependencies by either
- check the latest released in the score bazel registry
- check usage in other modules
docs-as-code is updated in a own PR.
Locally verified and did according clean up changes:
- remove of not needed defaults
- point to correct upstread ci-cd script
- newline added from automatic "fix" runs
@umaucher
Copy link
Contributor Author

umaucher commented Aug 7, 2025 •
edited
Loading

docs-as-code is handled in #61 ... now it is --> #64 (comment)

@umaucher umaucher mentioned this pull request Aug 7, 2025
Closed
@github-actions
Copy link

github-actions bot commented Aug 7, 2025 •
edited
Loading

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output 
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: e98882ec-4aad-4e84-9dc5-230d1a2b3146
Computing main repo mapping: 
Computing main repo mapping: 
DEBUG: Rule 'rules_boost+' indicated that a canonical reproducible form can be obtained by modifying arguments integrity = "sha256-aSViuHoOdF32Ue/Cx02/mOzyEebHMFuifjZs4GNWjsE="
DEBUG: Repository rules_boost+ instantiated at:
  <builtin>: in <toplevel>
Repository rule http_archive defined at:
  /home/runner/.bazel/external/bazel_tools/tools/build_defs/repo/http.bzl:394:31: in <toplevel>
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 1 packages loaded
Loading: 1 packages loaded
    currently loading: 
Analyzing: target //:license-check (2 packages loaded, 0 targets configured)
Analyzing: target //:license-check (2 packages loaded, 0 targets configured)

Analyzing: target //:license-check (61 packages loaded, 9 targets configured)

Analyzing: target //:license-check (74 packages loaded, 9 targets configured)

Analyzing: target //:license-check (127 packages loaded, 1917 targets configured)

Analyzing: target //:license-check (132 packages loaded, 2288 targets configured)

Analyzing: target //:license-check (132 packages loaded, 2288 targets configured)

Analyzing: target //:license-check (137 packages loaded, 4310 targets configured)

Analyzing: target //:license-check (139 packages loaded, 4554 targets configured)

DEBUG: Rule 'toolchains_llvm++llvm+llvm_toolchain_llvm' indicated that a canonical reproducible form can be obtained by modifying arguments _action_listener = <unknown object com.google.devtools.build.lib.packages.Attribute$LabelListLateBoundDefault>, _config_dependencies = [], _configure = False, _environ = [], _original_name = "llvm_toolchain_llvm"
DEBUG: Repository toolchains_llvm++llvm+llvm_toolchain_llvm instantiated at:
  <builtin>: in <toplevel>
Repository rule llvm defined at:
  /home/runner/.bazel/external/toolchains_llvm+/toolchain/rules.bzl:27:23: in <toplevel>
Analyzing: target //:license-check (139 packages loaded, 4554 targets configured)

INFO: Analyzed target //:license-check (140 packages loaded, 6489 targets configured).
[5 / 13] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_dash_license_checker+/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local ... (3 actions, 2 running)
ERROR: /home/runner/work/inc_mw_per/inc_mw_per/BUILD:48:21: Generating Dash formatted dependency file ... failed: missing input file '//:cargo_lock'
ERROR: /home/runner/work/inc_mw_per/inc_mw_per/BUILD:48:21: Generating Dash formatted dependency file ... failed: 1 input file(s) do not exist
Target //:license.check.license_check failed to build
Use --verbose_failures to see the command lines of failed build steps.
ERROR: /home/runner/work/inc_mw_per/inc_mw_per/BUILD:48:21 Generating Dash formatted dependency file ... failed: 1 input file(s) do not exist
INFO: Elapsed time: 193.056s, Critical Path: 0.44s
INFO: 10 processes: 10 internal.
ERROR: Build did NOT complete successfully
ERROR: Build failed. Not running target

@umaucher
Copy link
Contributor Author

umaucher commented Aug 8, 2025

docs-as-code is handled in #61

this is now part of the PR

@umaucher
docs: Update to docs-as-code 1.0.1+
7d014dc 
- workflows/docs.yml: adapt to new bazel target
- add top level //:doc target (with used needs)
- update to docs-as-code (with local overwrite to latest main for needs
  visibility fix), add dependencies for needs
- update conf.py based on docs-as-code/docs/conf.py
- update all references in docs:
   - platform prefix changed from SCORE_ to S-CORE_
   - persistency requirements prefix changed from __kvs__ to __persistency__
   - Some requirements got renamed (feat_req__kvs__stable_api not found
     anymore)
@umaucher umaucher marked this pull request as ready for review August 8, 2025 09:31
@umaucher
Copy link
Contributor Author

umaucher commented Aug 8, 2025

https://github.com/eclipse-score/inc_mw_per/actions/runs/16826826518/job/47665143508?pr=64 still uses the workflow file from main with the outdated target ... verified locally via bazel run //:docs

AlexanderLanin
AlexanderLanin approved these changes Aug 8, 2025
View reviewed changes
Copy link
Member

@AlexanderLanin AlexanderLanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a lot of changes at once, but LGTM

joshualicht
joshualicht approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@joshualicht joshualicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AlexanderLanin AlexanderLanin merged commit a1ef140 into eclipse-score:main Aug 8, 2025
10 of 11 checks passed
This was referenced Aug 8, 2025
Closed
Closed
@umaucher umaucher deleted the um_dep_updates branch August 8, 2025 10:12
atarekra pushed a commit to Valeo-S-CORE-Organization/persistency that referenced this pull request Nov 9, 2025
@umaucher
update dependencies (eclipse-score#64)
b0fa3a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderLanin AlexanderLanin AlexanderLanin approved these changes

+1 more reviewer

@joshualicht joshualicht joshualicht approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@umaucher @AlexanderLanin @joshualicht