Skip to content

Conversation

@masc2023
Copy link
Contributor

@masc2023 masc2023 commented Jun 2, 2025

Set REPLACE_ as reminder to change the context

@github-actions
Copy link

github-actions bot commented Jun 2, 2025

The created documentation from the pull request is available at: docu-html

@MaximilianSoerenPollak
Copy link
Contributor

Replacing the 'process/BUILD' with this here:

docs(
    conf_dir = "process",  # Where 'conf.py' is
    docs_targets = [
        {
            "suffix": "",  # latest main branch documentation build
        },
    ],
    source_dir = "process",  # Where the RST files are located
    source_files_to_scan_for_needs_links = [
        # Note: you can add filegroups, globs, or entire targets here.
    ],
)

Will then be enough to make it full doable / self sustained.

Although it would work with what you have as well, but since there is no more links, the import / declaration is not needed.

@MaximilianSoerenPollak
Copy link
Contributor

This PR eclipse-score/score#1185 does work.

However since 'process' v0.1.0 release is mentioned there, there is some stuff that doesn't quiet work until we upgrade.
The Issue that currently (in the PR) is happenign is that still only the 'latest' build works, even though bazel build //docs:docs_release does work and build it builds 'score_process//process:latest` instead of build, to avoid that circular dependency.

Once this PR here (together with some house keeping on the modules) is merged and released via the registry the PR in score can be used to fix the links etc.

@masc2023 masc2023 force-pushed the masc2023_remove_links_to_score branch from 06a17e5 to 32c7dce Compare June 3, 2025 04:40
@masc2023
Copy link
Contributor Author

masc2023 commented Jun 3, 2025

This PR eclipse-score/score#1185 does work.

However since 'process' v0.1.0 release is mentioned there, there is some stuff that doesn't quiet work until we upgrade. The Issue that currently (in the PR) is happenign is that still only the 'latest' build works, even though bazel build //docs:docs_release does work and build it builds 'score_process//process:latest` instead of build, to avoid that circular dependency.

Once this PR here (together with some house keeping on the modules) is merged and released via the registry the PR in score can be used to fix the links etc.

bazel build //docs:docs_release doe not work for me, only latest

Set REPLACE_ as reminder to change the context
@masc2023 masc2023 force-pushed the masc2023_remove_links_to_score branch from 32c7dce to 26743b7 Compare June 3, 2025 04:43
@masc2023 masc2023 marked this pull request as ready for review June 3, 2025 04:48
@MaximilianSoerenPollak
Copy link
Contributor

I think we can merge this.

Docs-as-code will most likely get a new release today, but until 'score' will be ready to merge (all links resolved etc.) there is some time too ran off the clock, and until then Process can have the new release of docs-ás-code too.

Copy link
Contributor

@MaximilianSoerenPollak MaximilianSoerenPollak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting can be done in followup

@MaximilianSoerenPollak MaximilianSoerenPollak merged commit 4df05b6 into main Jun 3, 2025
7 of 8 checks passed
@MaximilianSoerenPollak MaximilianSoerenPollak deleted the masc2023_remove_links_to_score branch June 3, 2025 05:40
FScholPer pushed a commit to mercedes-benz/score_process_description that referenced this pull request Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants