Merged
Conversation
sahithi-nukala
force-pushed
the
adding_rustc_flags
branch
from
cf2213f to
f5fdb54
Compare
castler
approved these changes
Jan 16, 2026
castler
requested changes
Jan 16, 2026
MODULE.bazel
Outdated
| exec_triple = "x86_64-unknown-linux-gnu", | ||
| extra_rustc_flags = [ | ||
| "-Clink-arg=-Wl,--no-as-needed", | ||
| "-Clink-arg=-lstdc++", |
Contributor
There was a problem hiding this comment.
Here we need to use:
-lc++
MODULE.bazel
Outdated
| exec_triple = "x86_64-unknown-linux-gnu", | ||
| extra_rustc_flags = [ | ||
| "-Clink-arg=-Wl,--no-as-needed", | ||
| "-Clink-arg=-lstdc++", |
Contributor
There was a problem hiding this comment.
In order to ensure the compatibility of Rust and C++, we add these linker flags to enable the case that rust_binaries can depend also on cc_libraries.
sahithi-nukala
force-pushed
the
adding_rustc_flags
branch
from
f5fdb54 to
0f4a98f
Compare
castler
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.