Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes GigaMap#set behavior after a restart by ensuring internalSet() properly loads lazily-referenced segments before updating an entity, and updates the restart test so it exercises set() without pre-loading data.
Changes:
- Update
GigaMap.Default#internalSetto useLazy#get()instead ofpeek()for level2/level1 segment access. - Adjust
SetTestto callset()immediately after reload (without a prior query) to reproduce/guard the lazy-loading scenario.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
gigamap/gigamap/src/main/java/org/eclipse/store/gigamap/types/GigaMap.java |
Ensures set() loads required lazy segments so updates work after reload. |
gigamap/gigamap/src/test/java/org/eclipse/store/gigamap/restart/SetTest.java |
Makes the restart test cover set() when segments haven’t been pre-loaded. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gigamap/gigamap/src/main/java/org/eclipse/store/gigamap/types/GigaMap.java
Outdated
Show resolved
Hide resolved
Use markChanged() instead of manual state-change flags to ensure Lazy entries are marked as used, preventing them from being cleared before storeChangedChildren() can persist the update.
zdenek-jonas
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GigaMap#internalSet, resolving incorrect value setting under specific conditions.GigaMap#settest functionality to ensure proper behavior after data reload.