Skip to content

[1006] Display isInitial and isDefault of FeatureValue Core tab#1008

Merged
AxelRICHARD merged 1 commit intoeclipse-syson:mainfrom
adaussy:ada/enh/i1006
Feb 11, 2025
Merged

[1006] Display isInitial and isDefault of FeatureValue Core tab#1008
AxelRICHARD merged 1 commit intoeclipse-syson:mainfrom
adaussy:ada/enh/i1006

Conversation

@adaussy
Copy link
Contributor

@adaussy adaussy commented Feb 7, 2025

Bug: #1006

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@AxelRICHARD
Copy link
Member

Could you also add a test in DetailsViewServiceTest please (see DetailsViewServiceTest#getCoreFeaturesOfPartUsage)

Bug: eclipse-syson#1006
Signed-off-by: Arthur Daussy <arthur.daussy@obeo.fr>
@AxelRICHARD AxelRICHARD merged commit 0cfcf96 into eclipse-syson:main Feb 11, 2025
3 checks passed
@adaussy adaussy deleted the ada/enh/i1006 branch March 3, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display FeatureValue.isDefault and FeatureValue.isInitial in core tab of FeatureValue concept

2 participants