[1048] Improve TransitionUsage to improve control of succession of#1095
Merged
AxelRICHARD merged 1 commit intoeclipse-syson:mainfrom Mar 11, 2025
Merged
[1048] Improve TransitionUsage to improve control of succession of#1095AxelRICHARD merged 1 commit intoeclipse-syson:mainfrom
AxelRICHARD merged 1 commit intoeclipse-syson:mainfrom
Conversation
adaussy
force-pushed
the
ada/fix/issue1048
branch
from
bd9898d to
ecf2b0c
Compare
AxelRICHARD
approved these changes
Mar 10, 2025
| result = actionUsage; | ||
| } | ||
| // See specification constraint deriveTransitionUsageSource in TransitionUsage | ||
| Feature sourceFeature = this.sourceFeature(); |
Member
There was a problem hiding this comment.
Nope, this is not what is described in the specification.
I will update it to conform to the sepcification.
| // TODO: implement this method | ||
| // Ensure that you remove @generated or mark it @generated NOT | ||
| return null; | ||
| return this.getOwnedMembership().stream() |
Member
There was a problem hiding this comment.
Nope, this is not what is described in the specification.
I will update it to conform to the specification.
| ``` | ||
| - Improve `PortDefinition` textual import by creating the required `ConjugatedPort` during the import process. | ||
|
|
||
| - Improve `TransitionUsage` import with _implit_ source. In the following example, the source of outgoing `TransitionUsages` of the `DecisionNode` are now properly resolved. |
Member
There was a problem hiding this comment.
- implit -> implicit
- Only one sentence per line please.
Could you please take the time to review your contributions, especially the sentences in the changelog and the release note please? It will help you finding the mistakes and fix them.
I will handle this one.
AxelRICHARD
force-pushed
the
ada/fix/issue1048
branch
from
ecf2b0c to
1cfc0f0
Compare
adaussy
force-pushed
the
ada/fix/issue1048
branch
from
1cfc0f0 to
d843929
Compare
AxelRICHARD
force-pushed
the
ada/fix/issue1048
branch
2 times, most recently
from
903b596 to
3c99c6b
Compare
Bug: eclipse-syson#1048 Signed-off-by: Arthur Daussy <arthur.daussy@obeo.fr>
AxelRICHARD
force-pushed
the
ada/fix/issue1048
branch
from
3c99c6b to
e5f23f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
action
Bug: #1048
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests