[1109] Add support for importing published libraries#1133
Merged
AxelRICHARD merged 1 commit intoeclipse-syson:mainfrom Mar 27, 2025
Merged
[1109] Add support for importing published libraries#1133AxelRICHARD merged 1 commit intoeclipse-syson:mainfrom
AxelRICHARD merged 1 commit intoeclipse-syson:mainfrom
Conversation
12 tasks
AxelRICHARD
reviewed
Mar 26, 2025
backend/application/syson-application/.settings/org.eclipse.jdt.core.prefs
Show resolved
Hide resolved
.../test/java/org/eclipse/syson/application/libraries/imports/SysONLibraryImportTestServer.java
Show resolved
Hide resolved
backend/application/syson-application/src/test/resources/scripts/dump-test-data.sh
Show resolved
Hide resolved
...n/syson-application/src/test/resources/application/libraries/imports/syson-test-database.sql
Show resolved
Hide resolved
Member
|
The code coverage level for |
AxelRICHARD
approved these changes
Mar 27, 2025
Member
AxelRICHARD
left a comment
There was a problem hiding this comment.
I will handle the comments myself, rebase and merge the PR.
Thank you!
...n-configuration/src/main/java/org/eclipse/syson/application/services/DetailsViewService.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/eclipse/syson/tree/explorer/view/services/SysONExplorerFilterService.java
Outdated
Show resolved
Hide resolved
...est/java/org/eclipse/syson/tree/explorer/view/services/SysONDefaultExplorerServicesTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/eclipse/syson/tree/explorer/view/services/SysONDefaultExplorerServicesTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/eclipse/syson/tree/explorer/view/services/SysONExplorerFilterServiceTest.java
Outdated
Show resolved
Hide resolved
Users may now import a previously-published library into their SysML projects. Importing is done by reference or by copy. * Backend ** Add omnibox command to import a published library. ** Add ISysONResourceService API and implementation with method isImported(Resource) that provides checks for either the specific 'imported' EAnnotation in the root elements, or the presence of a 'LibraryMetadataAdapter' that indicates that the resource comes from an imported-by-reference library. ** Refactored all calls to ElementUtil.isImported to ISysONResourceService.isImported, this way imported-by-reference libraries play well with existing SysON features (Explorer view, read-only mode, etc.). Where needed, constructors were also tweaked so that the service implementation gets injected. * Frontend ** Contribute to the omnibox of the SysON application the Sirius Web generic command to import a published library. ** Add merge strategy for extension point omniboxCommandOverrideContributionExtensionPoint in order to ease composability for downstream applications. * Tests ** Tweak integration tests database dumping script to include new Sirius Web tables 'public.semantic_data_dependency' and 'public.library' when dumping. ** Add integration tests database file that consists of: *** Project "MyLibrary" used to publish a library with two different versions "v1" and "v2" *** An empty project *** An empty project with a dependency to library "MyLibrary" v1. ** Add integration tests for library import-by-copy and import-by-reference. ** Add unit tests for SysONResourceService * Documentation ** Add documentation section for importing published libraries in the SysON user manual. ** Update release notes ** Update changelog * Misc ** Tweak JDT preference org.eclipse.jdt.core.formatter.continuation_indentation_for_array_initializer to fit Checkstyle expectations Bug: eclipse-syson#1109 Signed-off-by: Florent Latombe <florent.latombe@obeo.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users may now import a previously-published library into their SysML projects. Importing is done by reference or by copy.
Backend
Frontend
omniboxCommandOverrideContributionExtensionPoint in order to ease composability for downstream applications.
Tests
Documentation
Misc
org.eclipse.jdt.core.formatter.continuation_indentation_for_array_initializer to fit Checkstyle expectations
Bug: #1109
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests