Skip to content

[1324] Fix an issue that prevents ending up with a reference null#1325

Merged
AxelRICHARD merged 1 commit intomainfrom
fro/fix/batmobile-model
May 22, 2025
Merged

[1324] Fix an issue that prevents ending up with a reference null#1325
AxelRICHARD merged 1 commit intomainfrom
fro/fix/batmobile-model

Conversation

@frouene
Copy link
Contributor

@frouene frouene commented May 21, 2025

Bug: #1324

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@frouene frouene added this to the 2025.6.0 milestone May 21, 2025
@frouene frouene force-pushed the fro/fix/batmobile-model branch 2 times, most recently from 039891f to 1d87f49 Compare May 22, 2025 13:40
Copy link
Member

@AxelRICHARD AxelRICHARD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will handle the comments my self, rebase the PR and merge it. Thank you.

* `New Require constraint`
* `New Assume constraint`

- In the details view, fix an issue that prevents opening the references on a reference widget.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

details => Details (same for Explorer or any other Sirius Web view)

CHANGELOG.adoc Outdated
- https://github.com/eclipse-syson/syson/issues/1297[#1297] Fix an issue where the children of the `Package` graphical node lost their position when diagram is rendered after tab switching.
- https://github.com/eclipse-syson/syson/issues/1300[#1300] [general-view] Fix wrong tool section name found in some compartments' palette.
- https://github.com/eclipse-syson/syson/issues/1303[#1303] [general-view] Fix the name of `Constraint` creation tools inside `Requirement`.
- https://github.com/eclipse-syson/syson/issues/1324[#1324] [details] Fix an issue that prevents ending up with a reference `null`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the Reference widget

Bug: #1324
Signed-off-by: Florian ROUËNÉ <florian.rouene@obeosoft.com>
@AxelRICHARD AxelRICHARD force-pushed the fro/fix/batmobile-model branch from 1d87f49 to 07940fb Compare May 22, 2025 15:04
@AxelRICHARD AxelRICHARD merged commit d052aca into main May 22, 2025
4 of 5 checks passed
@AxelRICHARD AxelRICHARD deleted the fro/fix/batmobile-model branch May 22, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Opening references on a reference widget in a Batmobile model leads to an error

2 participants