Skip to content

[1448] Exclude referenced libraries from validation#1449

Merged
AxelRICHARD merged 1 commit intomainfrom
gda/enh/excludeReferencedLibrariesFromValidation
Jul 23, 2025
Merged

[1448] Exclude referenced libraries from validation#1449
AxelRICHARD merged 1 commit intomainfrom
gda/enh/excludeReferencedLibrariesFromValidation

Conversation

@gdaniel
Copy link
Contributor

@gdaniel gdaniel commented Jul 22, 2025

Fixes #1448

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

Bug: #1448
Signed-off-by: Gwendal Daniel <gwendal.daniel@obeosoft.com>

}

private void importLibraryV1() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved this away from the @BeforeEach because I needed to check stuff before the import.
In any case, I think this class should be reworked because it doesn't rely on the GraphQL APIs like the other integration tests (see for example line 207 projectEditingContextEventProcessor.handle which hooks into the event processor instead of a query runner).

This is not the scope of this PR though, so I adapted the code to fit my new test case.

@AxelRICHARD AxelRICHARD merged commit 2daae82 into main Jul 23, 2025
7 checks passed
@AxelRICHARD AxelRICHARD deleted the gda/enh/excludeReferencedLibrariesFromValidation branch July 23, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exclude referenced libraries from the validation

2 participants