[1487] Fix NPE thrown by getTreePath on non-view explorers#1490
Merged
AxelRICHARD merged 1 commit intomainfrom Aug 14, 2025
Merged
[1487] Fix NPE thrown by getTreePath on non-view explorers#1490AxelRICHARD merged 1 commit intomainfrom
AxelRICHARD merged 1 commit intomainfrom
Conversation
gdaniel
force-pushed
the
gda/fix/treePathOnNonViewExplorers
branch
from
bda7c65 to
44c412b
Compare
gdaniel
commented
Aug 13, 2025
...src/test/java/org/eclipse/syson/application/controller/explorer/view/SysONExplorerTests.java
Show resolved
Hide resolved
AxelRICHARD
reviewed
Aug 13, 2025
CHANGELOG.adoc
Outdated
| === Bug fixes | ||
|
|
||
| - https://github.com/eclipse-syson/syson/issues/1454[#1454] [import] Fix an issue where importing textual models with `MetadataAccessExpression` failed. | ||
| - https://github.com/eclipse-syson/syson/issues/1487[#1487] [explorer] Fix NPE thrown by `getTreePath` on non-view explorers. |
Member
There was a problem hiding this comment.
non-view explorers => may be something like
Explorers defined with Sirius Tree APIs instead of Sirius View DSL APIs
What do you think about ? If you are ok with that, please fix it everywhere in this PR.
Contributor
Author
There was a problem hiding this comment.
Sure, it is clearer than "non-view explorers". I have changed it (including in the description of the commit).
| return Objects.equals(sysonExplorerId, sourceId); | ||
| var sourceIdParameter = parameters.get("sourceId"); | ||
| if (sourceIdParameter != null && !sourceIdParameter.isEmpty()) { | ||
| var sourceId = parameters.get("sourceId").get(0); |
Member
There was a problem hiding this comment.
parameters.get("sourceId") => sourceIdParameter
gdaniel
force-pushed
the
gda/fix/treePathOnNonViewExplorers
branch
from
44c412b to
8907242
Compare
Bug: #1487 Signed-off-by: Gwendal Daniel <gwendal.daniel@obeosoft.com>
gdaniel
force-pushed
the
gda/fix/treePathOnNonViewExplorers
branch
from
8907242 to
2a53a97
Compare
AxelRICHARD
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: #1487
Fixes #1487
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests