[1452] Restrict InsertTextualSysMLMenuContribution to SysML elements (cont.)#1494
Merged
AxelRICHARD merged 1 commit intoeclipse-syson:mainfrom Aug 18, 2025
Merged
Conversation
flatombe
force-pushed
the
dev/FLA/1452/impl
branch
from
cbe77c9 to
6ba7f72
Compare
12 tasks
AxelRICHARD
reviewed
Aug 18, 2025
Member
AxelRICHARD
left a comment
AxelRICHARD
left a comment
There was a problem hiding this comment.
I will fix the last remarks and merge the PR, thank you.
.../org/eclipse/syson/tree/explorer/view/services/IRepresentationMetadataSearchServiceNoOp.java
Outdated
Show resolved
Hide resolved
...est/java/org/eclipse/syson/tree/explorer/view/services/SysONDefaultExplorerServicesTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/eclipse/syson/tree/explorer/view/services/SysONDefaultExplorerServicesTest.java
Outdated
Show resolved
Hide resolved
* Move contextual menu action "New objects from text" to the backend. Previously this command used the "kind" property of TreeItems to determine on which elements it was available. With Sirius Web deprecating this property, moving the action to the backend was the identified migration path. This should help the maintainability and testability of the action. * Add in the SysON explorer services, a service to determine on which elements this action is available. The default implementation only enables it on SysML model elements. * Update changelog and release notes accordingly. Bug: eclipse-syson#1452 Signed-off-by: Florent Latombe <florent.latombe@obeo.fr>
AxelRICHARD
force-pushed
the
dev/FLA/1452/impl
branch
from
6ba7f72 to
a2da2d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1456
This should fix #1452.
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests