Skip to content

[1565] Provide a way to duplicate semantic element in the Explorer view#1696

Merged
AxelRICHARD merged 1 commit intoeclipse-syson:mainfrom
adaussy:ada/enh/1565
Dec 9, 2025
Merged

[1565] Provide a way to duplicate semantic element in the Explorer view#1696
AxelRICHARD merged 1 commit intoeclipse-syson:mainfrom
adaussy:ada/enh/1565

Conversation

@adaussy
Copy link
Contributor

@adaussy adaussy commented Nov 21, 2025

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@adaussy adaussy force-pushed the ada/enh/1565 branch 4 times, most recently from 0f3308c to e0f2e5e Compare November 24, 2025 09:37
@AxelRICHARD AxelRICHARD added this to the 2026.1.0 milestone Nov 26, 2025
Copy link
Member

@AxelRICHARD AxelRICHARD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use cooldown branch here instead of main:
Capture d’écran 2025-11-26 à 10 48 43

@AxelRICHARD AxelRICHARD linked an issue Nov 26, 2025 that may be closed by this pull request
@adaussy adaussy changed the base branch from main to cooldown November 28, 2025 08:55
@AxelRICHARD
Copy link
Member

@adaussy The cooldown branch has been rebased over SysON 2025.10.6 (and SW 2025.10.6)

@adaussy adaussy changed the title [Merge only if SW version > 2025.10.5] Provide a way to duplicate semantic element in the Explorer view Provide a way to duplicate semantic element in the Explorer view Dec 1, 2025
@AxelRICHARD AxelRICHARD changed the title Provide a way to duplicate semantic element in the Explorer view [1565] Provide a way to duplicate semantic element in the Explorer view Dec 3, 2025
@AxelRICHARD AxelRICHARD force-pushed the cooldown branch 2 times, most recently from 7e3a59b to 6ace297 Compare December 3, 2025 13:25
@AxelRICHARD
Copy link
Member

I've rebased the PR on top of the latest version of the cooldown branch.

@AxelRICHARD
Copy link
Member

Here some points you need to address:

  • add a screenshot of the new popup in the doc and the release note
  • the new elements have the same elementId than their origin. elementIds should be different.
  • ElementContainmentFeatureProviderDelegate, SysMLContainmentMembershipLabelSwitch, SysONDuplicateDelegate, SysMLContainmentMembershipLabelSwitchTest have been added in syson-application-configuration. are you absolutely sure this is the appropriate place? Why it is not in syson-tree-explorer-view? Is there some cases where those services will be used by something else than the Explorer view?
    Thank you.

@adaussy
Copy link
Contributor Author

adaussy commented Dec 4, 2025

Here some points you need to address:

  • add a screenshot of the new popup in the doc and the release note
  • the new elements have the same elementId than their origin. elementIds should be different.
  • ElementContainmentFeatureProviderDelegate, SysMLContainmentMembershipLabelSwitch, SysONDuplicateDelegate, SysMLContainmentMembershipLabelSwitchTest have been added in syson-application-configuration. are you absolutely sure this is the appropriate place? Why it is not in syson-tree-explorer-view? Is there some cases where those services will be used by something else than the Explorer view?
    Thank you.

Done.

@adaussy adaussy force-pushed the ada/enh/1565 branch 2 times, most recently from a17bc13 to e904347 Compare December 4, 2025 14:43
@adaussy adaussy changed the base branch from cooldown to main December 4, 2025 14:45
</module>
<module name="JavadocVariable">
<property name="severity" value="ignore"/>
<property name="scope" value="protected"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you delete this line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorrry, it should be belong to thid PR. I will remove it and create another PR.
This line makes the IntelJ Checkstyle plugin fail. Since this rule is ignored I simply remove it so I can now use checkstyle inside my IDE.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's strange, you seem the only one to have the problem. Can you double check with another person please?

Bug: eclipse-syson#1565
Signed-off-by: Arthur Daussy <arthur.daussy@obeo.fr>
@AxelRICHARD AxelRICHARD merged commit 828685a into eclipse-syson:main Dec 9, 2025
3 checks passed
@adaussy adaussy deleted the ada/enh/1565 branch January 26, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide a way to duplicate semantic element in the Explorer view

2 participants