Skip to content

[1702] Provide a SysON version of the impact analysis tree#1715

Merged
AxelRICHARD merged 1 commit intomainfrom
gda/enh/sysml_impact_analysis
Dec 15, 2025
Merged

[1702] Provide a SysON version of the impact analysis tree#1715
AxelRICHARD merged 1 commit intomainfrom
gda/enh/sysml_impact_analysis

Conversation

@gdaniel
Copy link
Contributor

@gdaniel gdaniel commented Nov 28, 2025

Bug: #1702

Fixes #1702

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to re-create this file because it was quite outdated and there was some issues with the IDs of the elements.
The existing tests using this file do not rely on these IDs so they didn't need to be udpated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class is very similar to Sirius Web's DefaultChangeDescriptionDataTreeProvider.
As I pointed out in the corresponding Sirius Web PR, this code is quite unintuitive, because the change description we are parsing contains the changes to apply to undo the last operation. As a result, a REMOVE in the change description indicates that a feature as been added, not removed.

The main difference with Sirius Web's implementation is the usage of ISysONExplorerFilterService to filter out elements we don't want from the impact analysis tree.
I used the default filters as a baseline, but we can change it if you want (I think we should at least hide the membership, but I am not sure for the expose).

@gdaniel gdaniel force-pushed the gda/enh/sysml_impact_analysis branch from a8391c3 to e1b35ac Compare November 28, 2025 16:59
new ModuleCoverage("syson-table-services", 100.0),
new ModuleCoverage("syson-tree-explorer-view", 86.0),
new ModuleCoverage("syson-tree-services", 89.0)
new ModuleCoverage("syson-tree-services", 82.0)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lowered the coverage requirement because the impact analysis code can handle additions, but we don't have tools at the moment that perform additions and require an impact analysis.
Since this may happen in the near future (including in downstream applications), I didn't want to remove this piece of code to match the coverage requirements.

@AxelRICHARD AxelRICHARD force-pushed the cooldown branch 3 times, most recently from 7e3a59b to 6ace297 Compare December 3, 2025 13:25
@AxelRICHARD AxelRICHARD linked an issue Dec 3, 2025 that may be closed by this pull request
@gdaniel gdaniel force-pushed the gda/enh/sysml_impact_analysis branch from e1b35ac to b100c1c Compare December 5, 2025 14:12
@gdaniel gdaniel changed the base branch from cooldown to main December 5, 2025 14:13
@gdaniel gdaniel force-pushed the gda/enh/sysml_impact_analysis branch from b100c1c to c0e2cff Compare December 5, 2025 14:26
@gdaniel gdaniel force-pushed the gda/enh/sysml_impact_analysis branch from c0e2cff to 5d27631 Compare December 9, 2025 09:50
@AxelRICHARD
Copy link
Member

@gdaniel I will rebase and merge the PR, thank you.

@AxelRICHARD AxelRICHARD force-pushed the gda/enh/sysml_impact_analysis branch from 5d27631 to 5c1a1ce Compare December 10, 2025 08:23
Bug: #1702
Signed-off-by: Gwendal Daniel <gwendal.daniel@obeosoft.com>
@AxelRICHARD AxelRICHARD force-pushed the gda/enh/sysml_impact_analysis branch from 5c1a1ce to 2396a7a Compare December 15, 2025 07:18
@AxelRICHARD AxelRICHARD merged commit fa94a76 into main Dec 15, 2025
4 checks passed
@AxelRICHARD AxelRICHARD deleted the gda/enh/sysml_impact_analysis branch December 15, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Customize impact analysis dialog tree diff for SysML

2 participants