[1702] Provide a SysON version of the impact analysis tree#1715
[1702] Provide a SysON version of the impact analysis tree#1715AxelRICHARD merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
I had to re-create this file because it was quite outdated and there was some issues with the IDs of the elements.
The existing tests using this file do not rely on these IDs so they didn't need to be udpated.
There was a problem hiding this comment.
This class is very similar to Sirius Web's DefaultChangeDescriptionDataTreeProvider.
As I pointed out in the corresponding Sirius Web PR, this code is quite unintuitive, because the change description we are parsing contains the changes to apply to undo the last operation. As a result, a REMOVE in the change description indicates that a feature as been added, not removed.
The main difference with Sirius Web's implementation is the usage of ISysONExplorerFilterService to filter out elements we don't want from the impact analysis tree.
I used the default filters as a baseline, but we can change it if you want (I think we should at least hide the membership, but I am not sure for the expose).
a8391c3 to
e1b35ac
Compare
| new ModuleCoverage("syson-table-services", 100.0), | ||
| new ModuleCoverage("syson-tree-explorer-view", 86.0), | ||
| new ModuleCoverage("syson-tree-services", 89.0) | ||
| new ModuleCoverage("syson-tree-services", 82.0) |
There was a problem hiding this comment.
I lowered the coverage requirement because the impact analysis code can handle additions, but we don't have tools at the moment that perform additions and require an impact analysis.
Since this may happen in the near future (including in downstream applications), I didn't want to remove this piece of code to match the coverage requirements.
7e3a59b to
6ace297
Compare
e1b35ac to
b100c1c
Compare
b100c1c to
c0e2cff
Compare
...a/org/eclipse/syson/tree/impactanalysis/services/SysONChangeDescriptionDataTreeProvider.java
Show resolved
Hide resolved
...a/org/eclipse/syson/tree/impactanalysis/services/SysONChangeDescriptionDataTreeProvider.java
Outdated
Show resolved
Hide resolved
...a/org/eclipse/syson/tree/impactanalysis/services/SysONChangeDescriptionDataTreeProvider.java
Outdated
Show resolved
Hide resolved
...a/org/eclipse/syson/tree/impactanalysis/services/SysONChangeDescriptionDataTreeProvider.java
Show resolved
Hide resolved
...a/org/eclipse/syson/tree/impactanalysis/services/SysONChangeDescriptionDataTreeProvider.java
Show resolved
Hide resolved
c0e2cff to
5d27631
Compare
|
@gdaniel I will rebase and merge the PR, thank you. |
5d27631 to
5c1a1ce
Compare
Bug: #1702 Signed-off-by: Gwendal Daniel <gwendal.daniel@obeosoft.com>
5c1a1ce to
2396a7a
Compare
Bug: #1702
Fixes #1702
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Auto review
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc?CHANGELOG.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests