[1766] Prevent the creation of redundant Subsetting, Redefinition and Subclassifications#1768
Merged
AxelRICHARD merged 1 commit intomainfrom Dec 17, 2025
Merged
Conversation
AxelRICHARD
reviewed
Dec 17, 2025
Member
AxelRICHARD
left a comment
AxelRICHARD
left a comment
There was a problem hiding this comment.
I will handle the last small remarks myself, rebase and merge the PR.
Thank you!
| String hasExistingSubsetting = "hasExistingSubsetting"; | ||
|
|
||
| var feedback = this.viewBuilderHelper.newChangeContext() | ||
| .expression(ServiceMethod.of1(DiagramQueryAQLService::infoMessage).aqlSelf("'A subsetting already exists between these elements.'")) |
Member
There was a problem hiding this comment.
One little thing I forgot to tell you: you can use AQLUtils.aqlString(String) to avoid putting quotes
| image::release-notes-library-update-impact-analysis-with-tree.png[Impact analysis with change tree, width=65%,height=65%] | ||
|
|
||
| - In diagrams, when attempting to create a redundant feature typing between `Elements` which already have one, an informative message is displayed instead: | ||
| - In diagrams, when attempting to create some edges between `Elements` which already have one of the same type, an informative message is displayed instead. |
Member
There was a problem hiding this comment.
edges => graphical edges (we try to use graphical nodes and graphical edges vocabulary everywhere)
Bug: #1766 Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
AxelRICHARD
force-pushed
the
pcd/enh/prevent-redundant-relations
branch
from
2dd624c to
d46cba4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: #1766
Signed-off-by: Pierre-Charles David pierre-charles.david@obeo.fr
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Auto review
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc?CHANGELOG.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests