Skip to content

[1863] Show a message when dropping an already visible element on a diagram#2007

Merged
AxelRICHARD merged 1 commit intomainfrom
pcd/enh/dnd-existing-node-feedback
Feb 20, 2026
Merged

[1863] Show a message when dropping an already visible element on a diagram#2007
AxelRICHARD merged 1 commit intomainfrom
pcd/enh/dnd-existing-node-feedback

Conversation

@pcdavid
Copy link
Copy Markdown
Contributor

@pcdavid pcdavid commented Feb 17, 2026 •
edited
Loading

Bug: #1863
Signed-off-by: Pierre-Charles David pierre-charles.david@obeo.fr

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@pcdavid pcdavid linked an issue Feb 17, 2026 that may be closed by this pull request
Dropping an elements on a diagram which is already visible does not give any feedback #1863
Closed
@pcdavid pcdavid added this to the 2026.3.0 milestone Feb 17, 2026
@pcdavid pcdavid force-pushed the pcd/enh/dnd-existing-node-feedback branch 2 times, most recently from 68e59c9 to 5317c3d Compare February 18, 2026 09:55
@pcdavid pcdavid marked this pull request as ready for review February 18, 2026 09:55
@AxelRICHARD
Copy link
Copy Markdown
Member

AxelRICHARD commented Feb 19, 2026

Please read and check all relevant checkboxes.

@pcdavid
[1863] Show a message when dropping an already visible element on a d…
3471d08 
…iagram

Bug: #1863
Signed-off-by: Pierre-Charles David <pierre-charles.david@obeo.fr>
@pcdavid pcdavid force-pushed the pcd/enh/dnd-existing-node-feedback branch from 5317c3d to 3471d08 Compare February 20, 2026 09:15
@AxelRICHARD AxelRICHARD merged commit d1aca8a into main Feb 20, 2026
4 checks passed
@AxelRICHARD AxelRICHARD deleted the pcd/enh/dnd-existing-node-feedback branch February 20, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AxelRICHARD AxelRICHARD AxelRICHARD approved these changes

Assignees

No one assigned

Labels

pr: to review soon priority: low

Projects

None yet

Milestone

2026.3.0

Development

Successfully merging this pull request may close these issues.

Dropping an elements on a diagram which is already visible does not give any feedback

2 participants

@pcdavid @AxelRICHARD