[897] Add support for ConcernDefinition in diagram 'General View'#927
Merged
AxelRICHARD merged 4 commits intoeclipse-syson:mainfrom Jan 7, 2025
Merged
[897] Add support for ConcernDefinition in diagram 'General View'#927AxelRICHARD merged 4 commits intoeclipse-syson:mainfrom
AxelRICHARD merged 4 commits intoeclipse-syson:mainfrom
Conversation
12 tasks
AxelRICHARD
force-pushed
the
dev/PR2
branch
3 times, most recently
from
0b9a1d8 to
0894d18
Compare
AxelRICHARD
reviewed
Jan 6, 2025
doc/content/modules/user-manual/pages/release-notes/2025.2.0.adoc
Outdated
Show resolved
Hide resolved
flatombe
force-pushed
the
dev/PR2
branch
4 times, most recently
from
6cd4433 to
46f5af6
Compare
Varargs arguments were in the wrong order so the failure message was something like: "NodeDescription 1 should contain or reuse at least GV Compartment ConcernDefinition subjectParameter NodeDescription as its child" Now it should be: "NodeDescription 'GV Compartment ConcernDefinition subjectParameter' should contain or reuse at least 1 NodeDescriptions" Signed-off-by: Florent Latombe <florent.latombe@obeo.fr>
* 'ConcernDefinition' is essentially a 'RequirementDefinition', both semantically and graphically. * Update changelog and release notes accordingly. Bug: eclipse-syson#897 Signed-off-by: Florent Latombe <florent.latombe@obeo.fr>
Bug: eclipse-syson#897 Signed-off-by: Florent Latombe <florent.latombe@obeo.fr>
These tests should validate the creation, in the 'General View' diagram, of ConcernDefinition nodes and of sub-nodes in its compartments. Note that some compartments are not tested because the creation tool requires additional UI interactions and our integration test framework does not support such cases. Bug: eclipse-syson#897 Signed-off-by: Florent Latombe <florent.latombe@obeo.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is meant to be merged after #926.
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Project management
priority:andpr:labels been added to the pull request? (In case of doubt, start with the labelspriority: lowandpr: to review later)area:,type:)Changelog and release notes
CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adocbeen updated to reference the relevant issues?CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Key highlightssection indoc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?CHANGELOG.adoc+doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?Documentation
Tests