fix test crash on Ubuntu with Node 22+ #14984
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes eclipse-theia#14980 Contributed on behalf of STMicroelectronics Signed-off-by: Thomas Mäder <t.s.maeder@gmail.com>
Member
Author
|
Seems like to update fixes the handling of the underlying crash in the test |
Contributor
|
the job still seems to fail? |
Member
Author
But not the crash itself. Seems like some native is crashing the test process due to a double free(). To find out what's happening, we would have to obtain a core dump, but since it's not happening on my machine, I don't know how to do that. |
The core tests crash on Linux with Node 22+ as Node is much more strict in its memory handling. Fixes the crash by: - fixing listener leak in keybinding tests - making sure file watcher installed by logger-cli is unsubscribed
Member
|
Tests on Ubuntu 22 have been more stable lately, also with #16272, so I’m closing this for now. |
github-project-automation
bot
moved this from Waiting on reviewers
to Done
in PR Backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #14980
How to test
This is supposed to fix the PR tests on Ubuntu.
Follow-ups
Breaking changes
Attribution
Contributed on behalf of STMicroelectronics
Review checklist
Reminder for reviewers