refactor: use detectProtocolSchemes from @thingweb/td-utils for check…#29
Conversation
hasanheroglu
commented
Jul 21, 2024
- I replaced the logic in checkBinding funciton with detectProtocolSchemes from @thingweb/td-utils.
- I was not able to test since I am not familiar with node-red. Maybe I can get help with that.
- Closes Refactor binding finder #17
…Binding logic Signed-off-by: Hasan Eroglu <hasanheroglu@gmail.com>
egekorkan
left a comment
There was a problem hiding this comment.
Looks fine, thanks @hasanheroglu ! @hidetak do you want to review this PR as well?
|
Thank you for the modification to use the function to identify scheme. |
Signed-off-by: Hasan Eroglu <hasanheroglu@gmail.com>
|
Hey @hidetak, I made some changes, tested it locally, and it seems to work fine. |
|
Thank you for your consideration! However, I think the method you modified is better because it can be used in environments where there is no Internet connection or where a proxy is required.
Thank you very much ! |
Signed-off-by: Hasan Eroglu <hasanheroglu@gmail.com>
hidetak
left a comment
There was a problem hiding this comment.
Thank you for the correction!