Skip to content

Add flush call to fx_media_format#89

Merged
fdesbiens merged 2 commits into
eclipse-threadx:devfrom
Ralino:fix-add-missing-flush-on-format
Jun 3, 2026
Merged

Add flush call to fx_media_format#89
fdesbiens merged 2 commits into
eclipse-threadx:devfrom
Ralino:fix-add-missing-flush-on-format

Conversation

@Ralino
Copy link
Copy Markdown

@Ralino Ralino commented Mar 16, 2026

Adds a call to the I/O driver with FX_DRIVER_FLUSH to fx_media_format() before uninitializing the driver.

Fixes Issue #88

Adds a call to the I/O driver with FX_DRIVER_FLUSH to fx_media_format()
before uninitializing the driver.

Fixes Issue eclipse-threadx#88
@fdesbiens fdesbiens requested a review from rahmanih March 25, 2026 21:31
@fdesbiens fdesbiens self-assigned this Mar 25, 2026
@fdesbiens
Copy link
Copy Markdown
Contributor

Thank you for this contribution, @Ralino.

@rahmanih Can you please have a look?

@fdesbiens fdesbiens changed the base branch from master to dev March 25, 2026 21:33
@fdesbiens fdesbiens moved this to In review in ThreadX Roadmap Apr 14, 2026
- Added blank line after #ifndef FX_MEDIA_STATISTICS_DISABLE for style consistency
- Used local driver variable instead of media_ptr->fx_media_driver_entry
- Removed early return on flush failure so FX_DRIVER_UNINIT is always
  called after FX_DRIVER_INIT, preventing driver resource leaks

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@fdesbiens
Copy link
Copy Markdown
Contributor

@Ralino and @rahmanih: The core fix in this PR looked good to me. I made a few minor changes. Let me know what you think.

@fdesbiens fdesbiens merged commit 2ca9829 into eclipse-threadx:dev Jun 3, 2026
1 check passed
@github-project-automation github-project-automation Bot moved this from In review to Done in ThreadX Roadmap Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants