Skip to content

Conversation

@sophokles73
Copy link
Contributor

crates.io does not support rendering AsciiDoc.
The README has been converted back to plain markdown and the
OFT tags have been hidden inside of HTML comments, in order to
not mess up the rendered document.

Once merged, I would like to publish this as v0.1.1 to crates.io ...

@sophokles73 sophokles73 added the bug Something isn't working label Jul 17, 2024
crates.io does not support rendering AsciiDoc.
The README has been converted back to plain markdown and the
OFT tags have been hidden inside of HTML comments, in order to
not mess up the rendered document.
@sophokles73 sophokles73 force-pushed the use_markdown_for_readme branch from a9a57e6 to 51b1ae6 Compare July 17, 2024 16:25
Copy link
Contributor

@AnotherDaniel AnotherDaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I prefer md anyways.

Copy link
Contributor

@PLeVasseur PLeVasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Made me wonder when I opened the entry on crates.io and saw the formatting looked whack.

Copy link
Contributor

@evshary evshary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophokles73 sophokles73 merged commit 099ff28 into eclipse-uprotocol:main Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants